Update to python 3.9 #828
Merged
Update to python 3.9 #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
from
bf51d95
to
88de940
Compare
Note that this commit does not remove the mock package from the Pipenv dependencies.
Note that this commit does not remove asynctest from the Pipenv dependencies.
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
from
19988b0
to
d717ddd
Compare
Askaholic
commented
Dec 7, 2021
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
from
d717ddd
to
5b3799b
Compare
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
4 times, most recently
from
2d29a91
to
3692f9e
Compare
Codecov Report
|
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
from
3692f9e
to
87d1365
Compare
Askaholic
requested review from
BlackYps,
ChessBerry,
Cheyans,
Exselsior100 and
KaletheQuick
|
Lots of files are touched because of the typing changes, but there isn't anything complicated going on there |
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
2 times, most recently
from
fad1f28
to
359c710
Compare
Askaholic
commented
Dec 12, 2021
BlackYps
reviewed
Dec 14, 2021
|
I think I'm going to remove the |
This reverts commit 27283fe.
Askaholic
force-pushed
the
update-py-3.9-sqlalchemy
branch
from
d08175e
to
bf3eaea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #827
Finally got the tests running on 3.9 without them spitting out hundreds of warnings. I had to remove a bit of deprecated functionality
by swapping the mock and asynctest packages with builtin unittest.mock equivalents.
Unfortunately aiomysql still uses deprecated functionality (and there is no hope of it being fixed since that project seems to have no maintainer anymore), so we have to just ignore the deprecation warningsFortunately aiomysql finally merged their open python3.9+ compatibility prs. Also it seems that either aiohttp hasn't properly declared its dependencies or pipenv is doing something weird, as I had to explicitly include typing_extensions in the dependencies since aiohttp tries to import it.I also went ahead and did a few refactors that are possible in 3.9:
list[str]instead ofList[str](this one touches basically every file)