Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 lab id in inputs name #28

Merged
merged 4 commits into from
Apr 18, 2024
Merged

23 lab id in inputs name #28

merged 4 commits into from
Apr 18, 2024

Conversation

ka-sarthak
Copy link
Collaborator

@ka-sarthak ka-sarthak commented Apr 18, 2024

In addition to setting inputs name, PR also improves the filtering and code structure.

  • Make a separate method for resolving references: get_resolved_section
  • Use get_resolved_section when making new SectionReferences based on "Input Entry Class"
  • Define the reset_input_references method, which is used in the normalize method of ELN class, and combines the following functions:
    • Get the existing references and create new references based on the "Input Entry Class"
    • normalize m_proxy_value to be of consistent form <entry>/#<section>
    • Filter out the repeated references based on lab_id and m_proxy_value
  • Name the input reference based on the lab-id or name (lab-id preferred over name) of the referenced section
    • Only if the name is None, it will be set by this method. If the name already exists (for example, added by the user), it will not be modified

@ka-sarthak ka-sarthak linked an issue Apr 18, 2024 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8737233577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.375%

Totals Coverage Status
Change from base Build 8630948480: 0.0%
Covered Lines: 27
Relevant Lines: 32

💛 - Coveralls

Copy link
Collaborator

@aalbino2 aalbino2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jut

@ka-sarthak ka-sarthak merged commit dad42da into develop Apr 18, 2024
4 checks passed
@ka-sarthak ka-sarthak deleted the 23-lab_id-in-inputs-name branch April 18, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lab_id in inputs name
3 participants