Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 support for rsm plots #78

Merged
merged 22 commits into from
Mar 13, 2024
Merged

70 support for rsm plots #78

merged 22 commits into from
Mar 13, 2024

Conversation

ka-sarthak
Copy link
Collaborator

No description provided.

@ka-sarthak ka-sarthak linked an issue Feb 12, 2024 that may be closed by this pull request
10 tasks
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just fix the q_norm thing.

src/nomad_measurements/xrd/IKZ.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/IKZ.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/IKZ.py Outdated Show resolved Hide resolved
src/nomad_measurements/utils.py Outdated Show resolved Hide resolved
src/nomad_measurements/utils.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/schema.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/schema.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/schema.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/schema.py Outdated Show resolved Hide resolved
src/nomad_measurements/xrd/schema.py Outdated Show resolved Hide resolved
@ka-sarthak
Copy link
Collaborator Author

@hampusnasstrom Thanks for the review! I have added your suggestions and also did some ruff formatting mostly on the code I touched. Please have a look :)

Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it now and everything works. I have some suggestions on the plots but I will write a separate issue for this. For now I will go ahead and merge this.

@hampusnasstrom hampusnasstrom merged commit 05bdf2c into main Mar 13, 2024
1 check passed
@hampusnasstrom hampusnasstrom deleted the 70-support-for-rsm-plots branch March 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for RSM plots
2 participants