Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vms comment handling, add parser for kratos metadata #63

Merged
merged 17 commits into from
Jun 28, 2024
Merged

Refactor vms comment handling, add parser for kratos metadata #63

merged 17 commits into from
Jun 28, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jun 18, 2024 •
edited

  • Refactor how the comments in vamas files (where most vendors write their metadata) are handled
  • Add handler for metadata from Kratos
  • update examples and test data
  • add test for parsing comments in Vamas files for all supported vendors

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited

Pull Request Test Coverage Report for Build 9560912033

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited

Pull Request Test Coverage Report for Build 9561457543

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

@sameyley sameyley mentioned this pull request Jun 20, 2024
Closed
This was linked to issues Jun 26, 2024
Problems parsing vms exported from KRATOS ESCAPE #61
Closed
VAMAS import fails for data processed in casa using range calibration. #62
Closed
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited

Pull Request Test Coverage Report for Build 9682153985

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9682153985

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

@lukaspie lukaspie self-assigned this Jun 26, 2024
@lukaspie lukaspie marked this pull request as ready for review June 26, 2024 15:16
@lukaspie lukaspie added bug Something isn't working enhancement New feature or request labels Jun 26, 2024
RubelMozumder
RubelMozumder requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@RubelMozumder RubelMozumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just started to review. I am not finished yet.

src/pynxtools_xps/kratos/metadata_kratos.py Outdated Show resolved Hide resolved
RubelMozumder
RubelMozumder reviewed Jun 27, 2024
View reviewed changes
src/pynxtools_xps/kratos/kratos_data_model.py Show resolved Hide resolved
src/pynxtools_xps/kratos/metadata_kratos.py Show resolved Hide resolved
src/pynxtools_xps/kratos/metadata_kratos.py Outdated Show resolved Hide resolved
src/pynxtools_xps/kratos/metadata_kratos.py Outdated Show resolved Hide resolved
src/pynxtools_xps/kratos/metadata_kratos.py Outdated Show resolved Hide resolved
src/pynxtools_xps/kratos/kratos_data_model.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited

Pull Request Test Coverage Report for Build 9695016539

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9695016539

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9695016539

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9695016539

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9695016539

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

@lukaspie lukaspie requested review from domna and removed request for sanbrock June 27, 2024 10:41
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited

Pull Request Test Coverage Report for Build 9695122820

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9695122820

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 34
Relevant Lines: 34
💛 - Coveralls

domna
domna reviewed Jun 27, 2024
View reviewed changes
tests/test_reader.py Outdated Show resolved Hide resolved
domna
domna approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some small comments you might consider fixing before merging

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited

Pull Request Test Coverage Report for Build 9708596154

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 48
Relevant Lines: 48
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9708596154

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9580060695: 0.0%
Covered Lines: 48
Relevant Lines: 48
💛 - Coveralls

@lukaspie lukaspie merged commit cf40e3c into main Jun 28, 2024
7 checks passed
@lukaspie lukaspie deleted the vms-kratos branch June 28, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

@RubelMozumder RubelMozumder RubelMozumder approved these changes

Assignees

@lukaspie lukaspie

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@lukaspie @coveralls @domna @RubelMozumder