-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor vms comment handling, add parser for kratos metadata #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukaspie
commented
Jun 18, 2024
•
edited
Loading
edited
- Refactor how the comments in vamas files (where most vendors write their metadata) are handled
- Add handler for metadata from Kratos
- update examples and test data
- add test for parsing comments in Vamas files for all supported vendors
Pull Request Test Coverage Report for Build 9560912033Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9561457543Details
💛 - Coveralls |
This was
linked to
issues
Jun 26, 2024
Pull Request Test Coverage Report for Build 9682153985Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9682153985Details
💛 - Coveralls |
RubelMozumder
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just started to review. I am not finished yet.
Pull Request Test Coverage Report for Build 9695016539Details
💛 - Coveralls |
4 similar comments
Pull Request Test Coverage Report for Build 9695016539Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9695016539Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9695016539Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9695016539Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9695122820Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9695122820Details
💛 - Coveralls |
RubelMozumder
approved these changes
Jun 27, 2024
domna
reviewed
Jun 27, 2024
domna
reviewed
Jun 27, 2024
domna
reviewed
Jun 27, 2024
domna
reviewed
Jun 27, 2024
domna
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only some small comments you might consider fixing before merging
Pull Request Test Coverage Report for Build 9708596154Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9708596154Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.