-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👽️ Resolve relative paths and links right at the beginning of a run #1551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think FCP-INDI/app-C-PAC-brainlife.io#13 is directly related to this PR. Re-running that Brainlife run on the dev branch to confirm. |
shnizzedy
force-pushed
the
enh/allow-links
branch
from
September 3, 2021 20:41
9545a7b
to
6f87606
Compare
shnizzedy
force-pushed
the
enh/allow-links
branch
from
September 9, 2021 19:38
3ce6b95
to
2b38667
Compare
Included in #1531 |
This was referenced Sep 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
datalad run
failing withFileNotFoundError
sFixes
Fixes 🐛 Run error + Return code: 1 = exit code 0? app-C-PAC-brainlife.io#11 by @shnizzedy
Description
get_resource_from_prov
to returnNone
ifprov
is empty.1
when C-PAC finishes with an error.These changes should resolve a few crashes but shouldn't alter any outputs from runs that were already succeeding.
Technical details
The main thing here is setting local variables
bids_dir
andoutput_dir
toos.path.realpath()
of the passed args immediately after parsing the argsC-PAC/dev/docker_data/run.py
Lines 333 to 349 in b8bdbf6
and then using those local variables everywhere we were using
args.bids_dir
andargs.output_dir
Checklist
Update index.md
).develop
branch of the repository.Developer Certificate of Origin
Developer Certificate of Origin