Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”– cpac v0.3.2: pull/upgrade; support C-PAC v1.8 #13

Merged
merged 44 commits into from
Mar 12, 2021
Merged

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Mar 11, 2021

Fixes

Fixes #2
Fixes #3
Fixes #8

Description

  • βž– Remove dependecy on Nipype
  • πŸ› Pass commandline arguments through to cpac crash
  • 🚸 Add pull / upgrade command
  • ⚑️🐳 Stop Docker containers when finished
  • πŸ‘½ Handle changes from C-PAC 1.7 to 1.8

Tests

  • πŸ‘· Move tests from Travis to GitHub Actions
  • πŸ‘· Refactored tests to run on a matrix of [Docker, Singularity] Γ— C-PAC v[1.7, 1.8] Γ— Python [3.6, 3.7, 3.8]
    To do:
    • Debug Singularity pull from Docker Hub in GitHub action. It works for me locally and on AWS, but consistently runs out of space on GitHub Actions:
    FATAL:   While making image from oci registry: error fetching image to cache: while building SIF from layers: packer failed to pack: while unpacking tmpfs: error unpacking rootfs: unpack layer: unpack entry: usr/local/miniconda/lib/python3.7/site-packages/torch/lib/libtorch.so: unpack to regular file: short write: write /tmp/build-temp-279665709/rootfs/usr/local/miniconda/lib/python3.7/site-packages/torch/lib/libtorch.so: no space left on device
    (e.g., https://github.com/FCP-INDI/cpac/runs/2081157871)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the primary branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made.
  • I updated the changelog.
  • I added or updated documentation: πŸ“ Document nested config changesΒ fcp-indi.github.io#248
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy marked this pull request as ready for review March 12, 2021 22:58
@shnizzedy shnizzedy merged commit e4b44ff into primary Mar 12, 2021
@shnizzedy shnizzedy deleted the develop branch March 12, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant