Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd 2777 update design system for special cards #1014

Merged

Conversation

AlexanderEerenberg
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 26, 2022

Coverage Status

Coverage decreased (-0.5%) to 88.19% when pulling 952bcad on FD-2777_update_design_system_for_special_cards into 9c04127 on develop.

@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fd-design-system ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 9:56AM (UTC)

src/components/card/HybridCard4.tsx Outdated Show resolved Hide resolved
src/components/card/HybridCard2.tsx Outdated Show resolved Hide resolved
src/components/article-link-card/LinkCard.tsx Outdated Show resolved Hide resolved
src/components/card/HorizontalCard4.module.scss Outdated Show resolved Hide resolved
src/components/card/HorizontalCard4.module.scss Outdated Show resolved Hide resolved
@AlexanderEerenberg AlexanderEerenberg merged commit 140c18c into develop Jul 27, 2022
@AlexanderEerenberg AlexanderEerenberg deleted the FD-2777_update_design_system_for_special_cards branch July 27, 2022 12:46
willemliufdmg added a commit that referenced this pull request Jul 28, 2022
* Updated dependencies

* Updated dependencies

* Updated dependencies

* Fd 2777 update design system for special cards (#1014)

* Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018)

* Added new cards to component library.
Added new cards to README.md

* FD-2886: Update read article cards 1, 2 and 4 (#1020)

Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl>
Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com>
Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
willemliufdmg added a commit that referenced this pull request Jul 28, 2022
* Updated dependencies

* Updated dependencies

* Updated dependencies

* Fd 2777 update design system for special cards (#1014)

* Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018)

* Added new cards to component library.
Added new cards to README.md

* FD-2886: Update read article cards 1, 2 and 4 (#1020)

Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* README.md

* Added ms teams release message

Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl>
Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com>
Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
willemliufdmg added a commit that referenced this pull request Aug 4, 2022
* Updated dependencies

* Updated dependencies

* Updated dependencies

* Fd 2777 update design system for special cards (#1014)

* Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018)

* Added new cards to component library.
Added new cards to README.md

* FD-2886: Update read article cards 1, 2 and 4 (#1020)

Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* README.md

* Added ms teams release message

* Fixed vertical card 6 image going out of bounds. (#1022)

Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* Updated dependencies

* Fixed tests

Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl>
Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com>
Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
willemliufdmg added a commit that referenced this pull request Aug 10, 2022
* Updated dependencies

* Updated dependencies

* Updated dependencies

* Fd 2777 update design system for special cards (#1014)

* Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018)

* Added new cards to component library.
Added new cards to README.md

* FD-2886: Update read article cards 1, 2 and 4 (#1020)

Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* README.md

* Added ms teams release message

* Fixed vertical card 6 image going out of bounds. (#1022)

Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* Updated dependencies

* Fixed tests

* Updated dependencies

Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl>
Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com>
Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
willemliufdmg added a commit that referenced this pull request Aug 17, 2022
* Updated dependencies

* Updated dependencies

* Updated dependencies

* Fd 2777 update design system for special cards (#1014)

* Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018)

* Added new cards to component library.
Added new cards to README.md

* FD-2886: Update read article cards 1, 2 and 4 (#1020)

Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* README.md

* Added ms teams release message

* Fixed vertical card 6 image going out of bounds. (#1022)

Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl>

* Updated dependencies

* Fixed tests

* Updated dependencies

* Updated dependencies

Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl>
Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com>
Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants