Fixed vertical card 6 image going out of bounds. #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Changed routes:
Commit 6e5de8b (https://fd-design-system-ig5yvc8ho-fdmediagroep.vercel.app). |
willemliufdmg
approved these changes
Aug 3, 2022
AlexanderEerenberg
deleted the
FD-2937_Vertical_card_6_image_is_being_shoved_down
branch
willemliufdmg
added a commit
that referenced
this pull request
Aug 4, 2022
* Updated dependencies * Updated dependencies * Updated dependencies * Fd 2777 update design system for special cards (#1014) * Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018) * Added new cards to component library. Added new cards to README.md * FD-2886: Update read article cards 1, 2 and 4 (#1020) Co-authored-by: Floris Jansen <floris.jansen@kpn.com> Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl> * README.md * Added ms teams release message * Fixed vertical card 6 image going out of bounds. (#1022) Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl> * Updated dependencies * Fixed tests Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl> Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com> Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
willemliufdmg
added a commit
that referenced
this pull request
Aug 10, 2022
* Updated dependencies * Updated dependencies * Updated dependencies * Fd 2777 update design system for special cards (#1014) * Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018) * Added new cards to component library. Added new cards to README.md * FD-2886: Update read article cards 1, 2 and 4 (#1020) Co-authored-by: Floris Jansen <floris.jansen@kpn.com> Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl> * README.md * Added ms teams release message * Fixed vertical card 6 image going out of bounds. (#1022) Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl> * Updated dependencies * Fixed tests * Updated dependencies Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl> Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com> Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
willemliufdmg
added a commit
that referenced
this pull request
Aug 17, 2022
* Updated dependencies * Updated dependencies * Updated dependencies * Fd 2777 update design system for special cards (#1014) * Fd 2918 hybrid card 4 without an image not display correctly horizontal card 4 without an image should not have fd background color (#1018) * Added new cards to component library. Added new cards to README.md * FD-2886: Update read article cards 1, 2 and 4 (#1020) Co-authored-by: Floris Jansen <floris.jansen@kpn.com> Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl> * README.md * Added ms teams release message * Fixed vertical card 6 image going out of bounds. (#1022) Co-authored-by: Willem Liu <willem.liu@fdmediagroep.nl> * Updated dependencies * Fixed tests * Updated dependencies * Updated dependencies Co-authored-by: AlexanderEerenberg <alexander.eerenberg@fdmediagroep.nl> Co-authored-by: floris-fd <89779242+floris-fd@users.noreply.github.com> Co-authored-by: Floris Jansen <floris.jansen@kpn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.