-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #21 - missing gsl_vector_free() call for 365 isotope bug. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neInterpolator interpolateT (hydroLines, hydroTime, hydroTemp) object is being created correctly.
…and torch49, but oscillations at late times in nova case.
…and torch49, but oscillations at late times in nova case.
…ion. No more oscillations.
…ion. No more oscillations. Nova and torch47 profiles look reasonably good.
…ion. No more oscillations. Nova and torch47 profiles look reasonably good.
…ion. No more oscillations. Nova and torch47 profiles look reasonably good.
…n temperature. Appears to be interpolating correctly in both temperature and density.
…16 isotope network.
…off. Added the corrections from guidry_dev1 branch to read last column in rates file output now by Java, and increased the size of character array to keep from cutting off the reaction string.
… Basic problem caused by java code outputting a -1 for the RG class for reactions of the form a+b->c+d+e+f. The -1 then gets used as an index, wreaking some havoc on determining quantitites like niso, which caused loops to go out of bounds. Fixed by defining a new RGclass=6, which corresponds to a bookkeeping class of the form a+b<->c+d+e+f, which will always have only one member (e.g., he3+li7-->n+p+he4+he4 is the only reaction in RG class 21 in the nova simulation) because ReacLib contains no 4-body reactions that could be the inverse. Now on read-in if the RG class is -1, it is converted automatically to 6. Should fix the Java code to output 6 instead of -1 for such cases so the conversion of -1 in the C++ code would no longer be required.
…lotsteps=50. Runs but gnufile is null for 100 plot steps.
…cation that the computation is not taking so long, but the i/o is very slow.
…uring run, as much as 84% of machine memory was being taken, so probably encountering memory problems for very large networks. This may be because we are storing so much stuff to plot at the end, and because some arrays are static and taking more space than required in some calculations.
…hole machine and using about 82% of the memory.
…eption of 365 work without segfaults.
…eption of 365 work without segfaults.
…rectly, at least at first glance.
…ginal Java benchmark cases.
…y with new step by step output files (data now in plot1.data, plot2.data, plot3.data, plot4.data.
…imestep to external files for later plotting. Thus we should no longer need the large arrays that are holding data to be output to data files at the end. Will switch now to new branch guidry_debugPlotOutput2 and begin removing those arrays and the statements to write the data to arrays.
…data to files to store until the end of the calculation. Checked that all plotting was still possible from the files plot1.data, plot2.data, plot3.data, and plot4.data, which are written to at each plot output step and not stored in the program.
…rgets[plotSteps], since we are outputting all plot data at each timestep to external files, rather then storing in arrays until the end of the calculation, where we were then writing those arrays to data files. Should greatly reduce the memory use.
…d rather than gap = nextPlotTime - t_saved to keep timestep from exceeding next plot step by too much.
Signed-off-by: Jay Jay Billings <jayjaybillings@gmail.com>
Signed-off-by: Jay Jay Billings <jayjaybillings@gmail.com>
Merged Mike's most recent changes from guidry_debugPlotOutput2. |
I ran the 134-isotope nova calculation with my version of the rv2minus
correction and the memory usage (17.4%) is the same as before the
correction. So if my version of the correction is valid, the missing free
was an error but is not the source of large memory usage.
Mike
…On Wed, Aug 17, 2022 at 2:10 PM Jay Jay Billings ***@***.***> wrote:
Merged Mike's most recent changes from guidry_debugPlotOutput2.
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEWWFHN2SAQ7HTE7STWQQMTVZUTKXANCNFSM562NTRUQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Your version calls gsl_vector_free(rv2minus) on line 2334 when it is uncommented, which is after the function exits with return 0 or return 2 as shown here:
That won't work. You have to call it before the if statements as I did here because the function has always executed due to it being an if/else statement:
|
…o free a GSL vector memory allocation. For the Nova134 test case memory usage is reduced from 17.4% to 0.1%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jay Jay Billings jayjaybillings@gmail.com