Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring bugfix: fix three small bugs in the tracer part #575

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactoring bugfix: fix three small bugs in the tracer part #575

wants to merge 12 commits into from

Commits on Mar 11, 2024

  1. fix bug in computation of vertical tracer gradient, since its used i… 

    …n the explicite part, dz in the gradient computation must be based on the actual hnode thickness not the hnode_new thickness!!!
    @patrickscholz
    patrickscholz committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c0c2c36 View commit details
    Browse the repository at this point in the history

  2. delete comments

    @patrickscholz
    patrickscholz committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9af5e83 View commit details
    Browse the repository at this point in the history

  3. do not use hnode_new when computing the vertical explicite part of th… 

    …e Redi diffusivity, since its the explicit part ist be hnode here!!!
    @patrickscholz
    patrickscholz committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ab15aef View commit details
    Browse the repository at this point in the history

  4. use the same kind of tracer for horizontal and vertical tracer gradie… 

    …nt, that are used within the Redi diffusivity. Sergey recommented to better user tr^N for both!!!
    @patrickscholz
    patrickscholz committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    73179d3 View commit details
    Browse the repository at this point in the history

  5. combine all three bugfixes into one

    @patrickscholz
    patrickscholz committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    294bf22 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. solve merge conflict

    @patrickscholz
    patrickscholz committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    69129b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactoring_bugfix_hnodein_difveRedi' into refactoring_… 

    …bugfix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
    @patrickscholz
    patrickscholz committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    11d035e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactoring_bugfix_tracer4tr_xyz' into refactoring_bugf… 

    …ix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
    @patrickscholz
    patrickscholz committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3d0c3ac View commit details
    Browse the repository at this point in the history

  4. delte obsolete comment

    @patrickscholz
    patrickscholz committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1213794 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. revert some changes that belonged to the DVD implementation, and will… 

    … come in an separate commit
    @patrickscholz
    patrickscholz committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    da54780 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactoring' into refactoring_bugfix_hnode_in_Trz_and_d… 

    …ifveR_which_tr_in_Trxy
    @patrickscholz
    patrickscholz committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2acd582 View commit details
    Browse the repository at this point in the history

  3. Update oce_ale_tracer.F90 

    delete unnecessary variable
    @patrickscholz
    patrickscholz committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ec67d7a View commit details
    Browse the repository at this point in the history