Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring bugfix: fix three small bugs in the tracer part #575

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

patrickscholz
Copy link
Contributor

Fix 3 small bugs in the tracer part of FESOM2:

  1. [which_hnode_in_tr_z] which hnode is used in the computation of the vertical tracer gradient: Since the vertical tracer gradient is used explicit vertical Redi diffusivity we have to use here the layerthickness hnode of time step n, not hnode_new of time step n+1.
  2. [hnode_in_difveR] which hnode is used in the computation explicit vertical Redi diffusivity: since its the explicit component we have to use here the layerthickness hnode of time step n, not hnode_new of time step n+1.
  3. [which_tr_4_tr_xy] actual in the code we use the Adams-Bashfort tracer to compute the horizontal tracer gradient and the tracer at time step n to compute the vertical tracer gradient that is later used to compute the horizontal and vertical explicite Redi diffusivity. It doesnt makes sense here to have different tracers for the horizontal and vertical tracer gradient. Sergey recommended to use for the horizontal and vertical tracer gradient the tracer at time steps n.

All three bugfixes have only minor changes on the outcome see below after one JRA55 cycle (temperature anomalies) !
grafik
grafik
grafik
grafik

…n the explicite part, dz in the gradient computation must be based on the actual hnode thickness not the hnode_new thickness!!!
…e Redi diffusivity, since its the explicit part ist be hnode here!!!
…nt, that are used within the Redi diffusivity. Sergey recommented to better user tr^N for both!!!
…bugfix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
@patrickscholz patrickscholz marked this pull request as ready for review March 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants