-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring bugfix: fix three small bugs in the tracer part #575
Open
patrickscholz
wants to merge
12
commits into
main
Choose a base branch
from
refactoring_bugfix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactoring bugfix: fix three small bugs in the tracer part #575
patrickscholz
wants to merge
12
commits into
main
from
refactoring_bugfix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the explicite part, dz in the gradient computation must be based on the actual hnode thickness not the hnode_new thickness!!!
…e Redi diffusivity, since its the explicit part ist be hnode here!!!
…nt, that are used within the Redi diffusivity. Sergey recommented to better user tr^N for both!!!
…bugfix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
…ix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
… come in an separate commit
…ifveR_which_tr_in_Trxy
delete unnecessary variable
JanStreffing
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 3 small bugs in the tracer part of FESOM2:
All three bugfixes have only minor changes on the outcome see below after one JRA55 cycle (temperature anomalies) !
![grafik](https://private-user-images.githubusercontent.com/50746878/312861180-96509819-9012-41cf-96d9-4b131edd858a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNzMxOTEsIm5iZiI6MTcyMTI3Mjg5MSwicGF0aCI6Ii81MDc0Njg3OC8zMTI4NjExODAtOTY1MDk4MTktOTAxMi00MWNmLTk2ZDktNGIxMzFlZGQ4NThhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAzMjEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTExNDZhMWExODZhNjNkZGRmMzJlNWIyMWVmMTY1NmZhMzlkZWFiMGZkMTk2NjFlNjQ1OTQ1NmQ1YjljY2MyMWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Q1frdjugGbVXlqqxN71Nb7I3Vh_-yjPJCfBMsnXF3fA)
![grafik](https://private-user-images.githubusercontent.com/50746878/312861250-c7d1486f-db6d-42fb-b045-1206312f6e22.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNzMxOTEsIm5iZiI6MTcyMTI3Mjg5MSwicGF0aCI6Ii81MDc0Njg3OC8zMTI4NjEyNTAtYzdkMTQ4NmYtZGI2ZC00MmZiLWIwNDUtMTIwNjMxMmY2ZTIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAzMjEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZjNDBkYzk0NDhiMGNmMmQ2OTUwYjEwZGUyMTVlYTBkMTM1Yzk1NTU2ZWVmNDhmN2RmZDEzNjlmYWFlMjE5ZDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WhGxFEvI9DtII9DJmJZPBemNn42XAOKeyvOOT_nfgxw)
![grafik](https://private-user-images.githubusercontent.com/50746878/312861357-b3752d8f-16fe-4945-b108-ed511682a945.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNzMxOTEsIm5iZiI6MTcyMTI3Mjg5MSwicGF0aCI6Ii81MDc0Njg3OC8zMTI4NjEzNTctYjM3NTJkOGYtMTZmZS00OTQ1LWIxMDgtZWQ1MTE2ODJhOTQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAzMjEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMxYTZjZTE4NjhiZTQ5ZjYwNzVhMDUyNWJmY2JjOWI3ZDY4MjAyZWUxZGYwZmEwMTUzZjFiYTM3OGVmMmRkYWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I7tLfuTX2zc1tfC5cEg4Y4oOJNVVvlsKWhczc_cfXqw)
![grafik](https://private-user-images.githubusercontent.com/50746878/312861398-bcc1b01f-cc4b-4279-aca1-4f0e0c34b14f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNzMxOTEsIm5iZiI6MTcyMTI3Mjg5MSwicGF0aCI6Ii81MDc0Njg3OC8zMTI4NjEzOTgtYmNjMWIwMWYtY2M0Yi00Mjc5LWFjYTEtNGYwZTBjMzRiMTRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAzMjEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiOTY2ZWYxNmY0YzY0MDM3YWM3ZThjNjNjZDg2YWU5YTBmOGJmMTA5YmNiNTZkYmExMjljN2Q2YWRhMWMwMzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Bhh1osE1eUPfW23pPYul2RDndZBb4HQWB4CPDTUvOgY)