Add Discret Variance Decay (DVD) diagnostic of Knut and Sergey #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dvection fluxes, and to store the old tracer value. prepare the header of the general compute_dvd routine
… end of the ocean timestep overwritten with timestep n+1
…h betweeen KK and SD DVD computation
…al REDI diffusivity. Before we used the new hnode to compute the gradient but it has to be done on the old hnode
…ebugging since Knuts diagnostic can obnly be used as a total
…e reasonable than before, however KK diagnostic still looks strange
…that vert. expl. Redi diffusivity can be antidissipativ
…bugfix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
…ix_hnode_in_Trz_and_difveR_which_tr_in_Trxy
… come in an separate commit
…ifveR_which_tr_in_Trxy
delete unnecessary variable
…es_diag.F90, src/oce_ale_tracer.F90, config/namelist.cvmix
…order, if it is not setted in namelist.tra
…cer gradients. Its was decided to use tr^n, which means that the tr_AB can be kicked out from the DVD computation
…e first ones isnt need anymore due to the AB2/3 order update, the later one isnt need anymore due to the fixed bug from tracer synchronisation of the tracer gradient computation
…esold(1, :, :), therefor allocate new array for trstar= (trold + tr)*0.5_WP
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new diagnostic flag in namelsit.io: ldiag_DVD
Add DVD diagnostic of Knut Klingbeil et al. 2014, Quantification of spurious dissipation and mixing – Discrete Variance Decay in a Finite-Volume framework. For Knuts diagnostic we are not able to split up the DVD in its singular component. There we are only able to quantify a total DVD, considering all effects that manipulates the tracer.
Add DVD diagnostic of Sergey Danilov after T. Banerjee et al. 2023, Discrete variance decay analysis of spurious mixing. In this diagnostic we are able to split up the DVD contributions in all of its components.
This commit already considers the changes made in Pull Request: Refactoring bugfix: fix three small bugs in the tracer part Refactoring bugfix: fix three small bugs in the tracer part #575. Since these changes had to be taken into account in the computation of DVD. So it would make sense to merge this to refactoring after Refactoring bugfix: fix three small bugs in the tracer part #575 has been merged. --> that also means that in moment the testcase will fail!
It also includes the path updates from ollie-->albedo for namelist.config and namelist.forcing