Support mixed domain assembly #2271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now, re-open later when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mixed domain assembly. Forms with test functions, trial functions, and coefficients defined over different meshes can be assembled. The user must provide a map to relate mesh entities in the integration domain to mesh entities in the mesh the function is defined over; this is best illustrated by the new tests.
The codimension 1 case requires this branch of FFCX. In a future PR, I will add permutations which are required in some cases.
There are still lots of parts of the code that need to be tidied up / refined. Any feedback on the implementation approach would be much appreciated.