-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CNodes as LNodes, add typing, process AST separately from creating it. #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just added some formatting for complex numbes and variable precision. Standard C needs the |
garth-wells
approved these changes
Sep 4, 2023
jorgensd
added a commit
to jorgensd/cbcbeatx
that referenced
this pull request
Sep 5, 2023
chrisrichardson
added a commit
that referenced
this pull request
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses removes CNodes, and replaces with a much slimmed-down "LNodes" which contains the basics:
Scalar
(same as tensor),Real
(same as geometry) andInt
but removes almost everything else.
Symbols
must now have aDataType
Additionally, the Abstract Syntax Tree (AST) which is generated is now processed separately in
c_implementation.py
, which will allow us to post-process into other languages/libraries in the future.This is quite a large PR, unfortunately, but I think it will move things in the right direction.