Remove usage of deprecated functions from the source code and testing #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 -m pytest -W error::DeprecationWarning -xvs .` passes
jorgensd
requested review from
dham,
jhale,
garth-wells,
mscroggs and
IgorBaratta
jorgensd
added a commit
to FEniCS/ffcx
that referenced
this pull request
Dec 23, 2022
…dd in hard asserts to catch all dolfinx/ffcx errors. Remove hard asserts once these have been fixed
jorgensd
commented
Dec 23, 2022
jorgensd
commented
Dec 23, 2022
garth-wells
approved these changes
Dec 24, 2022
garth-wells
added a commit
to FEniCS/ffcx
that referenced
this pull request
Dec 24, 2022
* Make sure that we hit no deprecation warnings. Linked to FEniCS/ufl#139 * More removal of ufl_domain * Fix valuenumbering * Small change to improve readability Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
|
Now that those other two PRs are merged, is this ready for the ffcx and dolfinx branches to be reverted to main? |
jorgensd
commented
Jan 3, 2023
jorgensd
commented
Jan 3, 2023
jorgensd
commented
Jan 3, 2023
|
Should we merge this, as it does not break anything, as is currently a blocker for a new DOLFINxrelease according to @garth-wells |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to: #132
This PR makes sure that no deprecation warnings are hit by tests, i.e.
python…3 -m pytest -W error::DeprecationWarning -xvs .passes.This only resolves the changes for FFCx/DOLFINx pipeline, and TSFC/Firedrake would have to systematically go through their code to avoid calling deprecated functions. The failing tests: https://github.com/FEniCS/ufl/actions/runs/3766640944/jobs/6403360685 indicates that most places in TSFC needs to change from the deprecated function