-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More AD review updates #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Please split this in one commit per fix with a terse but larger than 0 bytes explanation for each |
Removing english definitions of intermediates does not seem a good idea to me |
…which should be in letters.
a642b57
to
20ed752
Compare
I misunderstood the AD request. I put chapters and definitions back. I kept the change of how to indicate the definition of
Done. please review again. |
20ed752
to
a8d60b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-reviewed after the pr was rebased and this looks good to me. There are some remaining issues from Murray's review that I can fix, so I send a pull request after this one is merged.
nudging here to be responsive to the ietf review. |
Ive merged a bunch of these. Some hesitation i had with
Why should a version 3 or 4 specification contain such a recommandition ?
First and foremost we need to describe what is the correct bitstream and what is the correct output for an encoder to generate. Otherwise we will end up with incorrect bitstreams.
I dunno, that does more than move i also see "Warning: Too long line found (L770), 5 characters longer than 72 characters:" not sure where this was introduced |
I close this PR it as it is superseded by #202. |
This is part of the fixes requested in an IETF AD review.
A detailed answer, line per line of the review, is coming.