Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2.8 #171

Closed
wants to merge 265 commits into from
Closed

Release/2.8 #171

wants to merge 265 commits into from

Conversation

richardbushell
Copy link

Sorry can't commit pull request myself, and couldn't see an issues tab, but please fix ffmpeg writing ISOM as major brand in MP4 files:

<FileTypeBox MajorBrand="isom" MinorVersion="512">

ISOM cannot be a major brand! It should be:

<FileTypeBox MajorBrand="mp42" MinorVersion="0">

This causes problems afterwards.

richardpl and others added 30 commits September 16, 2015 12:50
@richardpl
avfilter/af_ladspa: process all channels for nb_handles > 1
fb0d419 
Signed-off-by: Paul B Mahol <onemda@gmail.com>
(cherry picked from commit dc1050a)
@Nevcairiel
hevc: properly handle no_rasl_output_flag when removing pictures from…
41aa6b2 
… the DPB

Fixes ticket #4185.

Reviewed-By: Mickael Raulet <Mickael.Raulet@insa-rennes.fr>
Signed-off-by: Hendrik Leppkes <h.leppkes@gmail.com>
@jamrial
doc: mention libavcodec can decode Opus natively
ddbb8d5 
Signed-off-by: James Almer <jamrial@gmail.com>
(cherry picked from commit fd9ac48)
@michaelni
MAINTAINERS: add 2.8, drop 2.2
a3db855 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/mjpegdec: Fix decoding RGBA RCT LJPEG
08fc0d7 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 055e56e)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
swscale/swscale: Fix "unused variable" warning
9801c95 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 0ae40c5)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
lavf/webvttenc: Require webvtt file to contain exactly one WebVTT str…
9bbcd1c 
…eam.

Not requiring this can end up producing hilariously broken files
together with -c:s copy (e.g. a webvtt file containing binary subtitle data).

Signed-off-by: Simon Thelen <ffmpeg-dev@c-14.de>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit b842326)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avutil/log: fix zero length gnu_printf format string warning
3fedd64 
This should fix warning reported by fate client:
http://fate.ffmpeg.org/report.cgi?time=20150917113121&slot=x86_32-linux-gnu-gcc-4.5.1-have_6regs.
Untested.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 63cdb6e)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
cmdutils: Filter dst/srcw/h
2a6103a 
Dimensions / pixel formats for scaling must be set through the -s / pix_fmt options
or the scale / format filters. Otherwise there are mismatches between whet is
in/output to the scaler and for what the scaler is configured

Fixes Ticket4856

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a0af9fd)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@grandao @michaelni
swscale: fix ticket 4850
a8d0dcb 
(cherry picked from commit 77367f6)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/ffv1: seperate slice_count from max_slice_count
d4b1fe7 
Fix segfault with too large slice_count
Fixes Ticket4879

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit aa6c43f)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/rangecoder: Check e
3cd1be9 
Fixes hang.nut

Found-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit b2955b6)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@grandao @michaelni
swscale: fix ticket #4877
01bf0a1 
(cherry picked from commit a8602dd)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@cgisquet @michaelni
dnxhddec: decode and use interlace mb flag
f5f9c16 
This bit is 1 in some samples, and seems to coincide with interlaced
mbs and CID1260. 2008 specs do not know about it, and maintain qscale
is 11 bits. This looks oversized, but may help larger bitdepths.

Currently, it leads to an obviously incorrect qscale value, meaning
its syntax is shifted by 1. However, reading 11 bits also leads to
obviously incorrect decoding: qscale seems to be 10 bits.

However, as most profiles still have 11bits qscale, the feature is
restricted to the CID1260 profile.

The encoder writes 12 bits of syntax, last and first bits always 0,
which is now somewhat inconsistent with the decoder, but ends up with
the same effect (progressive + reserved bit).

Partially fixes ticket #4876.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2801a13)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@jermy @michaelni
dnxhddata: correct weight tables
61fd5a3 
CID 1260 (as evidenced by incorrect decoding of a sample from ticket
4876) seems to use incorrect weight tables. It appears those tables
were not zigzag-scanned.

Apply zigzag on weight tables for new CIDs 1258, 1259, and 1260, and
fix an incorrect chroma table for CID 1256.

Fixes last issue from ticket #4876.

Found-by: Christophe Gisquet <christophe.gisquet@gmail.com>
Signed-off-by: Christophe Gisquet <christophe.gisquet@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 428424f)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/ffv1dec: Explicitly check read_quant_table() return value
97340bd 
Forwards the error code, avoids potential integer overflow

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 10bbf6c)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/ffv1dec: Fix off by 1 error in quant_table_count check
837113a 
Fixes: invalid_read.nut
Found-by: Paul B Mahol <onemda@gmail.com>

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2d221d9)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/x86/sbrdsp: Fix using uninitialized upper 32bit of noise
818ebcb 
Fixes crash
Fixes: flicker-1.scout3d21443372922.28.m4a

Found-by: Dale Curtis <dalecurtis@google.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 1b82b93)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@DeHackEd @michaelni
libavformat/hlsenc: Use of uninitialized memory unlinking old files
83d75c7 
Fixes ticket#4900

Signed-off-by: DHE <git@dehacked.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 76e3f82)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/httpauth: Add space after commas in HTTP/RTSP auth header
6dcd2eb 
This fixes access to Grandstream cameras, which return 401 to ffmpeg
otherwise.
VLC sends Authorization: header with spaces between parameters, and it
is known to work with Grandstream devices and broad range of other HTTP
and RTSP servers, so author considers switching to such behaviour safe.
Just for record - RFC 2617 (HTTP Auth) does not specify the need in
spaces, so this is not a bug of FFmpeg.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit fdb3283)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@sva-img @michaelni
avcodec/mips: build fix for MSA
7236080 
Modified sps and pps access from old HEVCContext(s) structure to newly introduced HEVCParamSets(ps).

Signed-off-by: Shivraj Patil <shivraj.patil@imgtec.com>
Commit in master: b0732b0
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@sva-img @michaelni
avcodec/mips: build fix for MSA 64bit
a931ad5 
Modified datatype of function argument (pitch from int32_t to ptrdiff_t).

Signed-off-by: Shivraj Patil <shivraj.patil@imgtec.com>
Commit in master: 322e960
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@ubitux @michaelni
avformat/srtdec: fix number check for the first character
1d9d300 
(cherry picked from commit d161a2a)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@ubitux @michaelni
avformat/srtdec: more lenient first line probing
64b6596 
Fixes Ticket #4898
(cherry picked from commit 7218352)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/vobsub: compare correct packet stream IDs
eca7b0d 
The stream ID is essentially an arbitrary number defined by the .idx
file headers. They have to match the IDs in the .sub stream. The vobsub
demuxer assumed the IDs would just start from 0, increassing by 1 for
each stream. This is not correct. In the sample I had, the IDs were
starting from 1, leading to no subtitles being displayed at all.

Fix this by using the correct stream ID.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a47ad06)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@jamrial
configure: check for ID3D11VideoContext
4082402 
Should fix compilation with mingw-w64 trunk, where ID3D11VideoDecoder is available
but ID3D11VideoContext still isn't.

Signed-off-by: James Almer <jamrial@gmail.com>
(cherry picked from commit b8e4df4)
@ubitux
avformat/srtdec: make sure we probe a number
ee1bcd3 
Fixes regression since 7218352: WebVTT
files were matching the SRT probing.

(cherry picked from commit 40d9d6d)
@cehoyos
avcodec/mp3: fix skipping zeros
291a2f1 
Commits 43bc5cf and c5371f7 add code for skipping initial zeros in mp3
packets. This code forgot to report to the user that data was skipped at
all.

Since audio codecs allow partial packet decoding, the user application
has to rely on the return value. It will remove the data reported as
consumed by the decoder, and feed it to the decoder again. This resulted
in the mp3 frame after the zero region to be decoded over and over
again, until the zero region was finally skipped by the application.

Fix this by including the amount of skipped bytes to the number of
consumed bytes returned by the decode call.

Fixes trac ticket #4890.
(cherry picked from commit cb1da9f)
@pszemus @cehoyos
lavf/img2dec: Fix memory leak
635831c 
Fixes #4886

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 01dd7e0)
@richardpl @cehoyos
avcodec/pngdec: reset has_trns after every decode_frame_png()
39df4d2 
Fixes #4887.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
(cherry picked from commit 1d0487f)
michaelni and others added 28 commits January 15, 2016 12:30
@michaelni
avcodec/motion_est: Fix mv_penalty table size
6457cd1 
Fixes out of array read

Found-by: Tyson Smith <twsmith@mozilla.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5b4da8a)

Conflicts:

	libavcodec/motion_est.h
@loudmax @michaelni
avfilter/vf_scale: set proper out frame color range
3fb97a0 
Prevents that following scalers in the filter chain will do unintentional color range conversions.
Fixes Ticket #5096

Signed-off-by: Thomas Mundt <loudmax@yahoo.de>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 73ce816)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/mpegvideo_enc: Clip bits_per_raw_sample within valid range
3686155 
Fixes out of array read
Fixes: test_case-mdc.264 (b47be15a120979f5a1a945c938cbef33)

Found-by: Tyson Smith <twsmith@mozilla.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 13f266b)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/ivfenc: fix division by zero
d79b6dd 
Fixes Ticket 5115

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5c8467a)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat: Add integer fps from 31 to 60 to get_std_framerate()
cb4ba74 
Fixes Ticket 5106

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2039b3e)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/mss2: Check for repeat overflow
df4ee16 
Fixes: mss2_left_shift.wmv

Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e273dad)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/mjpegdec: Fix negative shift
34e06ce 
Fixes: mjpeg_left_shift.avi

Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit d86d7b2)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/g2meet: Check for ff_els_decode_bit() failure in epic_decode_…
9cad208 
…run_length()

Fixes invalid shift
Fixes: g2m_left_shift_2.wmv

Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 030c7f0)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/dvdec: Fix "left shift of negative value -254"
b8382a1 
Fixes: dvdec_left_shift.avi

Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 93ac72a)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/aacdec_template: Check id_map
e5567f2 
Fixes index out of bounds error
Fixes: aac_index_out_of_bounds.wmv

Found-by: Piotr Bandurski <ami_stuff@o2.pl>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5908638)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/wavpackenc: Headers are per channel
f05e0e7 
Fixes: 1b8b83a53bfa751f01b1daa65a4758db/signal_sigabrt_7ffff6ae7cb7_7488_403f71d1a2565b598d01b6cb110fac8f.aiff
Fixes: assertion failure

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 26757b0)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/wavpackenc: Check the number of channels
d7f7586 
They are stored in a byte, thus more than 255 is not possible

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 59c915a)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/mpeg4video: Check time_incr
d408261 
Fixes assertion failure
Fixes out of memory access

Fixes: test_casex.ivf

Found-by: Tyson Smith <twsmith@mozilla.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7c97946)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/asfenc: Check pts
f459afd 
Fixes integer overflow
Fixes: 0063df8be3aaa30dd6d76f59c8f818c8/signal_sigsegv_7b7b59_3634_bf418b6822bbfa68734411d96b667be3.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7c0b84d)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/aviobuf: Fix end check in put_str16()
90c2256 
Fixes out of array read
Fixes: 03c406ec9530e594a074ce2979f8a1f0/asan_heap-oob_7dec26_4664_37c52495b2870a2eaac65f53958e76c1.flac

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 115fb6d)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@cdump @michaelni
avformat/hls: forbid all protocols except http(s) & file
b7d54d6 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7145e80)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
swscale/yuv2rgb: Factor YUVRGB_TABLE_LUMA_HEADROOM out
c781a1e 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5e5f82a)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
swscale/yuv2rgb: Increase YUV2RGB table headroom
1fd9556 
This makes SWS more robust
Fixes: 07650a772d98aa63b0fed6370dc89037/asan_heap-oob_27ddeaf_2657_2c81ff264dee5d9712cb3251fb9c3bbb.264
Fixes: out of array read

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8f3a9a8)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
swscale/utils: Detect and skip unneeded sws_setColorspaceDetails() calls
cdac68f 
This avoids running various table inits unnecessarily

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit cc538e9)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
swscale: Move VScalerContext into vscale.c
be9b893 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7b6e689)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
swscale/vscale: Check that 2 tap filters are bilinear before using bi…
07da255 
…linear code

Fixes: out of array reads
Fixes: 07e8b9c5d348ccdf7add0f37de20cf6c/asan_heap-oob_27e8df7_6849_e56653f768070ec8cb52f587048444c2.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit eb7802a)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/pngenc: Replace memcpy by av_image_copy()
0c5a71f 
Fixes out of array access
Fixes: 0cf176e6d3ab9fe924f39738e513f547/asan_generic_4a54aa_3431_aaa28be1cb32e307a9890cad06f84fba.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7ec9c5c)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avcodec/pngenc: Fix mixed up linesizes
4676e20 
Fixes out of array accesses
Fixes: 0cf176e6d3ab9fe924f39738e513f547/asan_generic_4a54aa_3431_aaa28be1cb32e307a9890cad06f84fba.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8f4c3e4)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/hls: More strict url checks
23b903a 
No case is known where these are needed

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6ba42b6)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
avformat/hls: Even stricter URL checks
28f89bc 
This fixes a null pointer dereference at least

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit cfda1be)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
Update for 2.8.5
e303ca3 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@jamrial @michaelni
configure: bump copyright year to 2016
0639289 
Signed-off-by: James Almer <jamrial@gmail.com>
(cherry picked from commit 7812997)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@jamrial @michaelni
avcodec/wavpackenc: print channel count in av_log call
b8fa3ff 
Fixes a warning with -Wformat-extra-args
(cherry picked from commit 17e7fdf)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@TimothyGu
Copy link
Member

Hi,

Please read our bug reporting policies and file a ticket at our bug tracker.

Thank you!

@TimothyGu TimothyGu closed this Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone