Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-based ImageFactory #11

Closed
pointan opened this issue Feb 11, 2021 · 0 comments · Fixed by #14
Closed

Type-based ImageFactory #11

pointan opened this issue Feb 11, 2021 · 0 comments · Fixed by #14
Assignees
@pointan
Labels
confirmed Request was accepted and will be worked on

Comments

@pointan
Copy link
Member

pointan commented Feb 11, 2021

Create a Type-basedImageFactoryFactory, that returns a ImageFactory for a given type. This should be achieved, by adding a getSupportedType Method to the Factories, and use the Java https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/ServiceLoader.html to load different Factories, and use the one that supports the requested type.
@pointan pointan added the confirmed Request was accepted and will be worked on label Feb 11, 2021
@pointan pointan self-assigned this Feb 11, 2021
pointan added a commit that referenced this issue Feb 11, 2021
@pointan
#11 Change to type based image factory.
533381b
pointan added a commit that referenced this issue Feb 11, 2021
@pointan
#11 Added and updated changelog.
eabf319
pointan added a commit that referenced this issue Feb 11, 2021
@pointan
#11 Change to type based image factory.
4e0e904
pointan added a commit that referenced this issue Feb 11, 2021
@pointan
#11 Added and updated changelog.
9680b63
pointan added a commit that referenced this issue Feb 11, 2021
@pointan
#11 Adapted documentation to new TypeBasedImageFactoryFactory concept.
f44a591
pointan added a commit that referenced this issue Feb 11, 2021
@pointan
#11 Renamed TypeBasedImageFactoryFactory to ImageFactoryFactory.
e5a71df
@cpraschl cpraschl mentioned this issue Feb 12, 2021
Merged
@2er0 2er0 closed this as completed in #14 Feb 15, 2021
2er0 pushed a commit that referenced this issue Feb 15, 2021
@pointan @2er0
#11 Change to type based image factory.
ba5b1e6
2er0 pushed a commit that referenced this issue Feb 15, 2021
@pointan @2er0
#11 Added and updated changelog.
e1be178
2er0 pushed a commit that referenced this issue Feb 15, 2021
@pointan @2er0
#11 Adapted documentation to new TypeBasedImageFactoryFactory concept.
e317792
2er0 pushed a commit that referenced this issue Feb 15, 2021
@pointan @2er0
#11 Renamed TypeBasedImageFactoryFactory to ImageFactoryFactory.
1ff9c0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pointan pointan

Labels
confirmed Request was accepted and will be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend compatibility to different frameworks FHOOEAIST/imaging
1 participant
@pointan