Added support for SSE heartbeats #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarlehansen
reviewed
Oct 19, 2018
| @Scheduled(initialDelay = 15000, fixedRateString = "${fint.provider.sse.heartbeat:15000}") | ||
| public void sendHeartbeat() { | ||
| log.debug("Heartbeat"); | ||
| Multimap<String, FintSseEmitter> toBeRemoved = MultimapBuilder.hashKeys().linkedListValues().build(); |
There was a problem hiding this comment.
MultimapBuilder gives me a warning in intellij:
MultimapBuilder is marked unstable
Might not be a problem? I like the toBeRemoved.forEach... syntax
There was a problem hiding this comment.
Yeah, it's due to the @Beta annotation on that method. Shouldn't be a problem.
There was a problem hiding this comment.
Great, just merge it when you are ready.
jarlehansen
approved these changes
Oct 19, 2018
added 11 commits
December 14, 2018 08:09
According to javadoc on ResponseBodyEmitter.complete() there is no need to invoke this on IOExceptions. Furthermore, according to javadoc on ResponseBodyEmitter.onCompletion(), this handler is called on both timeouts and errors in addition to normal completions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds periodic heartbeat events to the SSE streams. It requires adapters to update to SSE libraries supporting empty events.
FINTLabs/fint-sse#1
FINTLabs/Fint.Sse#3