Fix connection problem for ipv6 peer #670

sulenn · 2020-06-29T12:34:14Z

Fix the problem that web3sdk cannot connect to IPv6 node probabilistically

ghost · 2020-06-29T12:34:53Z

Warnings are found on analyzing the commit 3eb9aae.

2 warnings:

⚠️ Goodcheck
⚠️ There are too many issues on the commit 3eb9aae for Sider to post all issues. Please review them on the analysis result.

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

ghost · 2020-06-29T12:34:53Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -92,10 +93,12 @@ public void retrySendMessage() {
                errorCode = ChannelMessageError.NODES_UNREACHABLE.getError();
                throw new Exception(" Failed to send message,all retry failed ");
            }
+            String host = getFromConnection().getHost();


[PMD Java] Found 'DU'-anomaly for variable 'host' (lines '96'-'143'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-29T12:34:53Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -92,10 +93,12 @@ public void retrySendMessage() {
                errorCode = ChannelMessageError.NODES_UNREACHABLE.getError();
                throw new Exception(" Failed to send message,all retry failed ");
            }
+            String host = getFromConnection().getHost();


[PMD Java] Avoid unused local variables such as 'host'. (view)

Rule Ruleset Priority

UnusedLocalVariable Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#unusedlocalvariable

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-29T12:34:53Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -92,10 +93,12 @@ public void retrySendMessage() {
                errorCode = ChannelMessageError.NODES_UNREACHABLE.getError();
                throw new Exception(" Failed to send message,all retry failed ");
            }
+            String host = getFromConnection().getHost();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

ghost · 2020-06-29T12:34:54Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -299,6 +300,13 @@ public void init() {
            String IP = connectionStr.substring(0, index);
            String port = connectionStr.substring(index + 1);

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-29T12:34:54Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -299,6 +300,13 @@ public void init() {
            String IP = connectionStr.substring(0, index);
            String port = connectionStr.substring(index + 1);

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-29T12:34:54Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {
+                throw new IllegalArgumentException(


[PMD Java] New exception is thrown in catch block, original stack trace may be lost (view)

Rule Ruleset Priority

PreserveStackTrace Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#preservestacktrace

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-29T12:36:06Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -95,7 +96,8 @@ public void retrySendMessage() {

            ChannelHandlerContext ctx =
                    fromChannelConnections.getNetworkConnectionByHost(
-                            getFromConnection().getHost(), getFromConnection().getPort());
+                            Inet6Address.getByName(getFromConnection().getHost()).getHostAddress(),
+                            getFromConnection().getPort());


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-29T12:36:06Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -106,7 +108,7 @@ public void retrySendMessage() {

                logger.debug(
                        "send message to  {}:{} success ",
-                        fromConnection.getHost(),
+                        Inet6Address.getByName(fromConnection.getHost()).getHostAddress(),


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:15Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -3,6 +3,7 @@
 import io.netty.buffer.ByteBuf;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.util.Timeout;
+import java.net.Inet6Address;


[PMD Java] Avoid unused imports such as 'java.net.Inet6Address' (view)

Rule Ruleset Priority

UnusedImports Best Practices 4

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#unusedimports

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:16Z

src/main/java/org/fisco/bcos/channel/client/ChannelResponseCallback2.java

@@ -95,7 +96,8 @@ public void retrySendMessage() {

            ChannelHandlerContext ctx =
                    fromChannelConnections.getNetworkConnectionByHost(
-                            getFromConnection().getHost(), getFromConnection().getPort());
+                            getFromConnection().getHost(),


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:16Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        String endpoint = "";
+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e)


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:17Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        String endpoint = "";
+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e)


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:18Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        String endpoint = "";
+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e)


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:18Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -299,6 +318,13 @@ public void init() {
            String IP = connectionStr.substring(0, index);
            String port = connectionStr.substring(index + 1);

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:18Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -299,6 +318,13 @@ public void init() {
            String IP = connectionStr.substring(0, index);
            String port = connectionStr.substring(index + 1);

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:18Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {
+                throw new IllegalArgumentException(


[PMD Java] New exception is thrown in catch block, original stack trace may be lost (view)

Rule Ruleset Priority

PreserveStackTrace Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#preservestacktrace

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:18Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-            String peer = connectionInfo.getHost() + ":" + connectionInfo.getPort();
-            ChannelHandlerContext ctx = networkConnections.get(peer);
+        for (Map.Entry<String, ChannelHandlerContext> entry : networkConnections.entrySet()) {
+            String peer = entry.getKey();


[PMD Java] Found 'DD'-anomaly for variable 'peer' (lines '598'-'598'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T03:16:19Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-            String peer = connectionInfo.getHost() + ":" + connectionInfo.getPort();
-            ChannelHandlerContext ctx = networkConnections.get(peer);
+        for (Map.Entry<String, ChannelHandlerContext> entry : networkConnections.entrySet()) {
+            String peer = entry.getKey();


[PMD Java] Found 'DU'-anomaly for variable 'peer' (lines '598'-'611'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:16:58Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:16:58Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -299,6 +315,13 @@ public void init() {
            String IP = connectionStr.substring(0, index);
            String port = connectionStr.substring(index + 1);

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:16:58Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -299,6 +315,13 @@ public void init() {
            String IP = connectionStr.substring(0, index);
            String port = connectionStr.substring(index + 1);

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:16:58Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {
+                throw new IllegalArgumentException(


[PMD Java] New exception is thrown in catch block, original stack trace may be lost (view)

Rule Ruleset Priority

PreserveStackTrace Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#preservestacktrace

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:16:58Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-            String peer = connectionInfo.getHost() + ":" + connectionInfo.getPort();
-            ChannelHandlerContext ctx = networkConnections.get(peer);
+        for (Map.Entry<String, ChannelHandlerContext> entry : networkConnections.entrySet()) {
+            String peer = entry.getKey();


[PMD Java] Found 'DD'-anomaly for variable 'peer' (lines '595'-'595'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:16:58Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-            String peer = connectionInfo.getHost() + ":" + connectionInfo.getPort();
-            ChannelHandlerContext ctx = networkConnections.get(peer);
+        for (Map.Entry<String, ChannelHandlerContext> entry : networkConnections.entrySet()) {
+            String peer = entry.getKey();


[PMD Java] Found 'DU'-anomaly for variable 'peer' (lines '595'-'608'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:27:11Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -304,6 +320,13 @@ public void init() {
                        " Invalid configuration, invalid IP string format, value: " + IP);
            }

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:27:11Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -304,6 +320,13 @@ public void init() {
                        " Invalid configuration, invalid IP string format, value: " + IP);
            }

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T04:27:12Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {
+                throw new IllegalArgumentException(


[PMD Java] New exception is thrown in catch block, original stack trace may be lost (view)

Rule Ruleset Priority

PreserveStackTrace Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#preservestacktrace

You can close this issue if no need to fix it. Learn more.

ywy2090 · 2020-06-30T06:11:19Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


endpoint = host + ":" + port;

ywy2090 · 2020-06-30T06:13:54Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


endpoint = host + ":" + port

ywy2090 · 2020-06-30T06:14:31Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            endpoint = Inet6Address.getByName(host).getHostAddress() + ":" + port;
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


endpoint = host + ":" + port

ghost · 2020-06-30T06:19:22Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            host = Inet6Address.getByName(host).getHostAddress();
+            endpoint = host + ":" + port;
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:22Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            host = Inet6Address.getByName(host).getHostAddress();
+            endpoint = host + ":" + port;
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:22Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -245,7 +246,13 @@ public ChannelHandlerContext randomNetworkConnection(
    }

    public ChannelHandlerContext getNetworkConnectionByHost(String host, Integer port) {
-        String endpoint = host + ":" + port;
+        String endpoint = "";


[PMD Java] Found 'DD'-anomaly for variable 'endpoint' (lines '249'-'252'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:22Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-        String endpoint = host + ":" + port;
+        String endpoint = "";
+        try {
+            host = Inet6Address.getByName(host).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:22Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            host = Inet6Address.getByName(host).getHostAddress();
+            endpoint = host + ":" + port;
+        } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:23Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-        String endpoint = host + ":" + port;
+        String endpoint = "";
+        try {
+            host = Inet6Address.getByName(host).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:23Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            host = Inet6Address.getByName(host).getHostAddress();
+            endpoint = host + ":" + port;
+        } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:23Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -304,6 +323,13 @@ public void init() {
                        " Invalid configuration, invalid IP string format, value: " + IP);
            }

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:24Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -304,6 +323,13 @@ public void init() {
                        " Invalid configuration, invalid IP string format, value: " + IP);
            }

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:19:24Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {
+                throw new IllegalArgumentException(


[PMD Java] New exception is thrown in catch block, original stack trace may be lost (view)

Rule Ruleset Priority

PreserveStackTrace Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#preservestacktrace

You can close this issue if no need to fix it. Learn more.

…cally

ghost · 2020-06-30T06:22:14Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-            String peer = connectionInfo.getHost() + ":" + connectionInfo.getPort();
-            ChannelHandlerContext ctx = networkConnections.get(peer);
+        for (Map.Entry<String, ChannelHandlerContext> entry : networkConnections.entrySet()) {
+            String peer = entry.getKey();


[PMD Java] Found 'DD'-anomaly for variable 'peer' (lines '595'-'595'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:14Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

-            String peer = connectionInfo.getHost() + ":" + connectionInfo.getPort();
-            ChannelHandlerContext ctx = networkConnections.get(peer);
+        for (Map.Entry<String, ChannelHandlerContext> entry : networkConnections.entrySet()) {
+            String peer = entry.getKey();


[PMD Java] Found 'DU'-anomaly for variable 'peer' (lines '595'-'608'). (view)

Rule Ruleset Priority

DataflowAnomalyAnalysis Error Prone 5

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#dataflowanomalyanalysis

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:14Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -304,6 +320,13 @@ public void init() {
                        " Invalid configuration, invalid IP string format, value: " + IP);
            }

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:14Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -304,6 +320,13 @@ public void init() {
                        " Invalid configuration, invalid IP string format, value: " + IP);
            }

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:15Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+            try {
+                IP = Inet6Address.getByName(IP).getHostAddress();
+            } catch (Exception e) {
+                throw new IllegalArgumentException(


[PMD Java] New exception is thrown in catch block, original stack trace may be lost (view)

Rule Ruleset Priority

PreserveStackTrace Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#preservestacktrace

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:16Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

@@ -260,12 +266,22 @@ public ChannelHandlerContext getNetworkConnectionByHost(String host, Integer por
     */
    public ChannelHandlerContext setAndGetNetworkConnectionByHost(
            String host, Integer port, ChannelHandlerContext ctx) {
+        try {
+            host = Inet6Address.getByName(host).getHostAddress();
+        } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:16Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            host = Inet6Address.getByName(host).getHostAddress();
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:16Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

        String endpoint = host + ":" + port;
        return networkConnections.put(endpoint, ctx);
    }

    public void removeNetworkConnectionByHost(
            String host, Integer port, ChannelHandlerContext ctx) {
+        try {
+            host = Inet6Address.getByName(host).getHostAddress();


[PMD Java] Potential violation of Law of Demeter (method chain calls) (view)

Rule Ruleset Priority

LawOfDemeter Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#lawofdemeter

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:16Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

        String endpoint = host + ":" + port;
        return networkConnections.put(endpoint, ctx);
    }

    public void removeNetworkConnectionByHost(
            String host, Integer port, ChannelHandlerContext ctx) {
+        try {
+            host = Inet6Address.getByName(host).getHostAddress();
+        } catch (Exception e) {


[PMD Java] Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block (view)

Rule Ruleset Priority

AvoidCatchingGenericException Design 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_design.html#avoidcatchinggenericexception

You can close this issue if no need to fix it. Learn more.

ghost · 2020-06-30T06:22:16Z

src/main/java/org/fisco/bcos/channel/handler/ChannelConnections.java

+        try {
+            host = Inet6Address.getByName(host).getHostAddress();
+        } catch (Exception e) {
+            logger.error("invalid host string format, value: " + host);


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost reviewed Jun 29, 2020

View reviewed changes

bxq2011hust approved these changes Jun 30, 2020

View reviewed changes

FISCO-BCOS deleted a comment Jun 30, 2020

ghost reviewed Jun 30, 2020

View reviewed changes

FISCO-BCOS deleted a comment Jun 30, 2020

ywy2090 reviewed Jun 30, 2020

View reviewed changes

ghost reviewed Jun 30, 2020

View reviewed changes

Fix the problem that web3sdk cannot connect to IPv6 node probabilisti…

3eb9aae

…cally

ghost reviewed Jun 30, 2020

View reviewed changes

sulenn closed this Jul 9, 2020

Fix connection problem for ipv6 peer #670

Fix connection problem for ipv6 peer #670

Conversation

sulenn commented Jun 29, 2020

ghost commented Jun 29, 2020 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jun 29, 2020 •

edited by ghost

Loading