Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace global variables pixel_progress etc with Progress class #531

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

d11mshepcar
Copy link
Contributor

I've replaced four global variables with a class that is passed around to fix issues when encoding/decoding from multiple threads as per issue #517

@hakonrk
Copy link

hakonrk commented Jun 7, 2019

Thank you @mshepcar for providing this patch! 👍 It fixed the problem I was having when trying to decode multiple FLIF images in parallel using threads (images came out monochrome for some reason). Makes me wonder why it has not yet been merged to master. Are there any known problems?

@artscoop
Copy link

Ping, this MR is one blocking point for adoption in a Python lib

@bjorn3
Copy link

bjorn3 commented Mar 21, 2020

Please note that FLIF is superseded by FUIF, which itself is superseded by JPEG-XL.

@artscoop
Copy link

Oh nice

@jonsneyers
Copy link
Member

Thanks for the improvement - sorry to have been so negligent in maintaining FLIF.

Like @bjorn3 said, FLIF is superseded by JPEG XL. So any project currently using FLIF should consider switching to libjxl.

@jonsneyers jonsneyers merged commit dca0bad into FLIF-hub:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants