Added option to disable cheat guard #58
Conversation
classes/manager.php
Outdated
| // Check if the user can capture this event, anti cheater method. | ||
| if (!$this->can_capture_event($event)) { | ||
| return; | ||
| if (get_config('enablecheatguard')) { |
There was a problem hiding this comment.
Is this working? This looks like it would check for a site-wide setting rather than the manager's instance setting. I think this should be using $this->get_config('enablecheatguard').
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <XMLDB PATH="blocks/xp/db" VERSION="20160224" COMMENT="XMLDB file for Moodle blocks/xp" | |||
| <XMLDB PATH="blocks/xp/db" VERSION="20170214" COMMENT="XMLDB file for Moodle blocks/xp" | |||
There was a problem hiding this comment.
Have you used the XMLDB Editor tool under Site administration > Development. The latter takes care of maintaining that XML file, it also providers the PHP upgrade code.
There was a problem hiding this comment.
Thanks! I wish I had known before... I could not agree more with the XMDLB Editor page:
"It makes the editing of tables/fields/keys/indexes almost a trivial task, allowing developers to spend the time coding and improving things instead of fighting with XML files and the errors caused by manual editing (of course, developers are free to use such extra time as desired - beers, dance, books, music...) ;-)"
|
Thanks for your pull request :). That would also be nice if you could merge your commits, if not I'll do it myself. |
|
What you mean by merging it myself? Giving me access to the repo? Are you sure? :) |
|
Heh, I meant rebase. Don't worry, I'll get it sorted. Hopefully I'll merge this soon. I'd just like to test it first. Thanks! |
|
I just re-implemented this myself, before I realized there was already a pull request for it. 🤦♂️ Anyways, when will this get merged? It is a feature that we could really use. Thanks! |
|
This has been manually merged. Thanks! |
Fixes #57