Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to plugin details page. #57

Open
jcaianirh opened this issue Apr 10, 2019 · 15 comments
Open

Add parameters to plugin details page. #57

jcaianirh opened this issue Apr 10, 2019 · 15 comments
Assignees
Labels
ChRIS Store help wanted Extra attention is needed

Comments

@jcaianirh
Copy link
Collaborator

Add parameters to plugin details page according to design here: https://github.com/FNNDSC/cube-design/blob/master/ChRIS-Store/mockups/plugin-details_parameters.1.png

@gagansk gagansk self-assigned this May 13, 2019
@mairin mairin added ChRIS Store help wanted Extra attention is needed labels Mar 30, 2021
@Aaishpra
Copy link
Contributor

hey, @mairin I would like to try working here.

@mairin
Copy link
Contributor

mairin commented Mar 31, 2021

Sure @Aaishpra - let me know if you have any questions.

@Aaishpra
Copy link
Contributor

Aaishpra commented Apr 1, 2021

@mairin i guess i have to make additions to this page but i couldn't find the right file which contained parameters (checked create-plugins,plugins and plugin files). It would be great if you can point out the right file to make these enhancements.
image

@PintoGideon
Copy link

PintoGideon commented Apr 2, 2021

Hey @Aaishpra , Do you have the react dev tools extension downloaded? This link here should help you get started.

Once you have that installed, just click on inspect element (right click and choose Inspect element) on the desired page in the UI, go to the components tab in the browser and look for the component name in the component tree. . You can then search for the component name in the ChRIS_store_ui's folder and that should point you to the file. The link should explain that better, but if you still have questions, let me know and I can point you to the file or add snapshots explaining this better.

@Aaishpra
Copy link
Contributor

Aaishpra commented Apr 3, 2021

Thanks @PintoGideon it helped the component was Pluginbody.js.
Now working on it will ask more questions if got stuck again

@Aaishpra
Copy link
Contributor

Aaishpra commented Apr 3, 2021

image
Hey, @PintoGideon @mairin the Are the parameters and other details here supposed to be similar for every plugin (means can be added via simple text) or we have to get these details from somewhere (means the parameters are supposed to be different for every plugin)?
If they are supposed to be different how can i get them?

@PintoGideon
Copy link

PintoGideon commented Apr 3, 2021

Hi @Aaishpra ,

The parameters and other details for a plugin are pulled from the backend through a JS client. You can find the documentation for the client here. The repo for the client is here.

You can take some time to familiarize yourself with this as it would benefit you for future tasks as well. You can go through the current codebase to see how the client is used. You can fetch the resources associated with each plugin using the id. The documentation for the client should show you how to do that. The response would include all the details you would need to create this page. Let me know if I can elaborate or explain myself better.

@Aaishpra
Copy link
Contributor

Aaishpra commented Apr 9, 2021

Hey, @PintoGideon I don't see any parameters associated with plugins on this URL http://localhost:8010/api/v1/ all I see is id, creation date, modification date, name, title, stars repo, and other details of the plugins.
Can you help?

@PintoGideon
Copy link

PintoGideon commented Apr 9, 2021

Hey @Aaishpra , Looks like from the js client's documentation, you can get the plugin parameters by doing this.

const parameters = await plugin.getPluginParameters();

The snippet above assumes you have the plugin fetched from the backend on which you want to fetch the parameters.
The idea here is once you have the plugin, you can fetch more resources like the plugin meta and the plugin parameters by making those get function calls (which ideally makes get requests behind the scenes). Let me know if this makes sense. I can definitely try and explain better,

@PintoGideon
Copy link

PintoGideon commented Apr 9, 2021

@Aaishpra , Just run through the examples here if you haven't. This usually clears things up. Again, feel free to ask as many questions you want.

Here is the relevant snippet for your needs:

Snippet

@Aaishpra
Copy link
Contributor

Thanks for this. I will update you soon

@mairin
Copy link
Contributor

mairin commented May 19, 2021

@Aaishpra Let me know if you are still interested in this ticket after the Outreachy application period, or if we should clear you as assignee.

@Aaishpra Aaishpra removed their assignment May 20, 2021
@Aaishpra
Copy link
Contributor

I have unassigned @mairin

@merilaclau
Copy link

Hi @mairin @PintoGideon
I'm an Outreachy applicant. Would love to try this one out =)
Could you assign this ticket to me?
Thanks in advance!

@laris678
Copy link

Hi @mairin @PintoGideon
I am an outreachy applicant 2022. I will like to do this , can you please assign this ticket to me
awaiting response
thanks

@jennydaman jennydaman assigned laris678 and unassigned merilaclau Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChRIS Store help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants