Merge pull request #1051 from jennydaman/istanbul

Improve coverage accuracy by replacing v8 coverage with Istanbul

.dockerignore

@@ -9,3 +9,5 @@ yarn-debug.log*
 yarn-error.log*
 test-results
 playwright-report
+.nyc_output
+coverage

.github/workflows/test.yml

@@ -28,11 +28,15 @@ jobs:
       env:
         TEST_SAFARI: yes
       run: npm run test:e2e
-    - name: Upload E2E test coverage
+    - name: Report coverage
+      id: report
       if: ${{ always() }}
+      run: npm run test:lcov
+    - name: Upload E2E test coverage
+      if: steps.report.outcome == 'success'
       uses: codecov/codecov-action@v4
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
-        files: coverage/clover.xml
+        files: coverage/lcov.info
         flags: e2etests
         fail_ci_if_error: true

.gitignore

@@ -9,6 +9,7 @@
 /coverage
 /test-results
 /playwright-report
+/.nyc_output
 
 # production
 /build

deleteCoverageData.ts

@@ -0,0 +1,10 @@
+import { FullConfig } from "playwright/test";
+import path from "path";
+import * as fsPromises from "node:fs/promises";
+
+async function globalSetup(_config: FullConfig) {
+  const nycOutput = path.join(process.cwd(), ".nyc_output");
+  await fsPromises.rm(nycOutput, { recursive: true, force: true });
+}
+
+export default globalSetup;