Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint with biome and format all files #1049

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

jennydaman
Copy link
Collaborator

biome is a JavaScript formatter and linter, i.e. a replacement for eslint and prettier.

  • Added LICENSE
  • Added .editorconfig
  • Removed eslint
  • Added biome
  • Added git hooks to require all changed code to be formatted (note: lint is not checked by git hooks)
  • Ran formatter

@jennydaman jennydaman marked this pull request as ready for review February 6, 2024 17:53
@jennydaman
Copy link
Collaborator Author

New NPM scripts:

  • npm run lint: checks for bad programming, e.g. any type
  • npm run fix: tries to fix trivial things
  • npm run fix: fixes everything it can, which may change code behavior
  • npm run fmt`: format code

Import statements on Mac are case-insensitive, causing collision with CreateFeed.tsx
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 339 lines in your changes are missing coverage. Please review.

Comparison is base (dfb2654) 73.80% compared to head (5c58962) 73.80%.

Files Patch % Lines
.../components/Pacs/components/SettingsComponents.tsx 37.37% 123 Missing and 1 partial ⚠️
src/components/Pacs/useSettings.tsx 28.81% 41 Missing and 1 partial ⚠️
src/components/Pipelines/ConfigurationPage.tsx 0.00% 13 Missing ⚠️
src/components/NodeDetails/NodeDetails.tsx 10.00% 9 Missing ⚠️
src/components/CreateFeed/createFeedHelper.ts 42.85% 7 Missing and 1 partial ⚠️
src/components/FeedTree/data.ts 22.22% 7 Missing ⚠️
src/components/Pipelines/TitleChange.tsx 22.22% 7 Missing ⚠️
src/store/resources/actions.ts 65.00% 6 Missing and 1 partial ⚠️
src/components/CreateFeed/PipelineContainter.tsx 50.00% 6 Missing ⚠️
src/components/NodeDetails/StatusTitle.tsx 0.00% 6 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   73.80%   73.80%   -0.01%     
==========================================
  Files         172      172              
  Lines       53448    53511      +63     
  Branches      664      666       +2     
==========================================
+ Hits        39447    39493      +46     
- Misses      13340    13352      +12     
- Partials      661      666       +5     
Flag Coverage Δ
e2etests 73.80% <48.24%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PintoGideon
Copy link
Collaborator

@jennydaman Thank you so much. Appreciate it !!

@PintoGideon PintoGideon merged commit 5f164d5 into FNNDSC:master Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants