Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore the idea of a store from which a user can install plugins #1198

Merged
merged 8 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@ VITE_PFDCM_URL="http://localhost:4005/"
VITE_PFDCM_CUBEKEY="local"
VITE_PFDCM_SWIFTKEY="local"
VITE_SOURCEMAP='false'

# Set URL for the store

VITE_CHRIS_STORE_URL= 'http://rc-live.tch.harvard.edu:32222/api/v1/'
3 changes: 1 addition & 2 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"useExhaustiveDependencies": "off"
},
"suspicious": {
"noExplicitAny": "off",
"noArrayIndexKey": "off"
"noExplicitAny": "off"
}
}
},
Expand Down
2 changes: 0 additions & 2 deletions playwright.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { defineConfig, devices, PlaywrightTestConfig } from "@playwright/test";


const SAFARI_BROWSERS: PlaywrightTestConfig["projects"] = [];

if (process.env.TEST_SAFARI?.toLowerCase().startsWith('y')) {
Expand Down Expand Up @@ -65,7 +64,6 @@ export default defineConfig({

...SAFARI_BROWSERS
],

webServer: {
command: "env USE_BABEL_PLUGIN_ISTANBUL=y npm run dev:public",
url: "http://localhost:25173",
Expand Down
11 changes: 4 additions & 7 deletions src/components/DisplayPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,9 @@ const DisplayPage = ({
const updateDropdownValue = (type: string) => {
setDropdownValue(type);
if (isPlugin) {
handlePluginSearch && handlePluginSearch("", dropdownValue.toLowerCase());
handlePluginSearch?.("", dropdownValue.toLowerCase());
} else {
handleComputeSearch &&
handleComputeSearch("", dropdownValue.toLowerCase());
handleComputeSearch?.("", dropdownValue.toLowerCase());
}
};
const dropdownItems = isPlugin
Expand Down Expand Up @@ -272,13 +271,11 @@ const DisplayPage = ({
aria-label="search"
onChange={(_event, value: string) => {
if (isPlugin) {
handlePluginSearch &&
handlePluginSearch(value, dropdownValue.toLowerCase());
handlePluginSearch?.(value, dropdownValue.toLowerCase());
}

if (isCompute) {
handleComputeSearch &&
handleComputeSearch(value, dropdownValue.toLowerCase());
handleComputeSearch?.(value, dropdownValue.toLowerCase());
}
}}
/>
Expand Down
3 changes: 2 additions & 1 deletion src/components/PluginCatalog/PluginCatalog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const PluginCatalog = () => {
itemCount: 0,
});

const { page, perPage, search, searchType } = pageState;
const { page, perPage, search, searchType, itemCount } = pageState;
const [selectedPlugin, setSelectedPlugin] = React.useState<any>();

const onSetPage = (_event: any, page: number) => {
Expand Down Expand Up @@ -77,6 +77,7 @@ const PluginCatalog = () => {
itemCount: pluginList.totalCount,
};
});

return newPluginPayload;
}
}
Expand Down
2 changes: 2 additions & 0 deletions src/components/PluginCatalog/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const { Paragraph } = Typography;

const CatalogPage = () => {
const dispatch = useDispatch();

React.useEffect(() => {
document.title = "Analysis Catalog";
dispatch(
Expand All @@ -20,6 +21,7 @@ const CatalogPage = () => {
}),
);
});

return (
<WrapperConnect>
<PageSection>
Expand Down
2 changes: 1 addition & 1 deletion src/components/SinglePlugin/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const SinglePlugin = () => {
const pluginInstances = isLoggedIn
? ((
await plugin.getPluginInstances({
limit: 20,
limit: 1000,
})
).getItems() as PluginInstance[])
: [];
Expand Down
Loading