Skip to content

Commit

Permalink
Fix bug in setSetting method.
Browse files Browse the repository at this point in the history
This is a static method and no callers use multi call to setSetting. Returning $this is not necessary and illegal.
  • Loading branch information
mastacontrola committed Jan 4, 2017
1 parent b27a006 commit b410732
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 42 deletions.
2 changes: 0 additions & 2 deletions packages/web/lib/fog/fogbase.class.php
Expand Up @@ -1918,8 +1918,6 @@ public static function setSetting($key, $value)
'',
array('value' => trim($value))
);

return $this;
}
/**
* Gets queued state ids.
Expand Down
Expand Up @@ -2,7 +2,7 @@ msgid ""
msgstr ""
"Project-Id-Version: fog-project-2\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-23 07:36-0400\n"
"Last-Translator: vspushbullet <vspushbullet@gmail.com>\n"
"Language-Team: German\n"
Expand Down Expand Up @@ -423,7 +423,7 @@ msgid "Array type"
msgstr "Array mit Daten"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -728,7 +728,7 @@ msgstr "Veranstaltung muss eine Zeichenfolge sein."
msgid "Key must be a string"
msgstr "Veranstaltung muss eine Zeichenfolge sein."

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -739,12 +739,12 @@ msgstr "Veranstaltung muss eine Zeichenfolge sein."
msgid "File"
msgstr "Datei"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "Linie"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-22 15:14-0400\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
Expand Down Expand Up @@ -422,7 +422,7 @@ msgid "Array type"
msgstr "Array of data"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -723,7 +723,7 @@ msgstr "Event must be a string"
msgid "Key must be a string"
msgstr "Event must be a string"

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -734,12 +734,12 @@ msgstr "Event must be a string"
msgid "File"
msgstr "File"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "Line"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-22 15:14-0400\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
Expand Down Expand Up @@ -425,7 +425,7 @@ msgid "Array type"
msgstr "Matriz de datos"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -726,7 +726,7 @@ msgstr "Evento debe ser una cadena"
msgid "Key must be a string"
msgstr "Evento debe ser una cadena"

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -737,12 +737,12 @@ msgstr "Evento debe ser una cadena"
msgid "File"
msgstr "Archivo"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "Línea"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-22 15:14-0400\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
Expand Down Expand Up @@ -425,7 +425,7 @@ msgid "Array type"
msgstr "Tableau de données"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -728,7 +728,7 @@ msgstr "Événement doit être une chaîne"
msgid "Key must be a string"
msgstr "Événement doit être une chaîne"

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -739,12 +739,12 @@ msgstr "Événement doit être une chaîne"
msgid "File"
msgstr "Fichier"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "Ligne"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-22 15:14-0400\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
Expand Down Expand Up @@ -425,7 +425,7 @@ msgid "Array type"
msgstr "Array di dati"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -724,7 +724,7 @@ msgstr "Evento deve essere una stringa"
msgid "Key must be a string"
msgstr "Evento deve essere una stringa"

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -735,12 +735,12 @@ msgstr "Evento deve essere una stringa"
msgid "File"
msgstr "File"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "linea"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
10 changes: 5 additions & 5 deletions packages/web/management/languages/messages.pot
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 21:45-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
Expand Down Expand Up @@ -389,7 +389,7 @@ msgid "Array type"
msgstr ""

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -658,7 +658,7 @@ msgstr ""
msgid "Key must be a string"
msgstr ""

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -669,12 +669,12 @@ msgstr ""
msgid "File"
msgstr ""

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr ""

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-22 15:14-0400\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
Expand Down Expand Up @@ -424,7 +424,7 @@ msgid "Array type"
msgstr "Matriz de dados"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -725,7 +725,7 @@ msgstr "Evento deve ser uma string"
msgid "Key must be a string"
msgstr "Evento deve ser uma string"

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -736,12 +736,12 @@ msgstr "Evento deve ser uma string"
msgid "File"
msgstr "Arquivo"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "Linha"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-01-03 15:30-0500\n"
"POT-Creation-Date: 2017-01-04 09:08-0500\n"
"PO-Revision-Date: 2016-05-22 15:14-0400\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
Expand Down Expand Up @@ -422,7 +422,7 @@ msgid "Array type"
msgstr "数据数组"

#: /var/www/fog/lib/fog/fogcontroller.class.php:907
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogbase.class.php:2125
#: /var/www/fog/lib/fog/fogftp.class.php:370
#: /var/www/fog/lib/pages/taskmobile.class.php:45
#: /var/www/fog/lib/pages/taskmanagementpage.class.php:964
Expand Down Expand Up @@ -719,7 +719,7 @@ msgstr "事件必须是字符串"
msgid "Key must be a string"
msgstr "事件必须是字符串"

#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogbase.class.php:2127
#: /var/www/fog/lib/fog/fogftp.class.php:372
#: /var/www/fog/lib/pages/fogconfigurationpage.class.php:2198
#: /var/www/fog/lib/pages/printermanagementpage.class.php:85
Expand All @@ -730,12 +730,12 @@ msgstr "事件必须是字符串"
msgid "File"
msgstr "文件"

#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogbase.class.php:2129
#: /var/www/fog/lib/fog/fogftp.class.php:374
msgid "Line"
msgstr "线"

#: /var/www/fog/lib/fog/fogbase.class.php:2133
#: /var/www/fog/lib/fog/fogbase.class.php:2131
#: /var/www/fog/lib/fog/fogftp.class.php:376
#: /var/www/fog/lib/db/mysql.class.php:189
msgid "Message"
Expand Down

0 comments on commit b410732

Please sign in to comment.