Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shipyard: introduce two new modes #263

Conversation

YASH-YADAV-dynamo
Copy link

@YASH-YADAV-dynamo YASH-YADAV-dynamo commented Apr 19, 2024

This is a draft pr
Made frontend of shipyard in two modes when shipyard is happening and when its not.

This PR fixes #261

Screenshot from 2024-04-19 10-12-43

Screenshot from 2024-04-19 10-12-28

Screenshot from 2024-04-19 10-12-21

@codecShivam
Copy link
Member

codecShivam commented Apr 30, 2024

Hey @YASH-YADAV-dynamo ,
Any updates on the PR? It's been over 2 weeks since it was opened.

Copy link
Member

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using Some better naming convention, rather than shipyard_no & shipyard_yes

Copy link
Member

@codecShivam codecShivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @YASH-YADAV-dynamo, focus on creating reusable components with multiple parts. This will help keep the codebase clean and organized. Additionally, consider defining data types for your various fields.

@YASH-YADAV-dynamo
Copy link
Author

yeah sure

@codecShivam
Copy link
Member

yeah sure

@YASH-YADAV-dynamo are you working on it?

@codecShivam codecShivam closed this Jun 8, 2024
@codecShivam codecShivam reopened this Jun 8, 2024
@YASH-YADAV-dynamo
Copy link
Author

Yeahh

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for dev-fosscu ready!

Name Link
🔨 Latest commit 6a1d1f6
🔍 Latest deploy log https://app.netlify.com/sites/dev-fosscu/deploys/66d35d3e663f910008c56f34
😎 Deploy Preview https://deploy-preview-263--dev-fosscu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants