Reduce repetitive code of Frontend Roadmap Component #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fossc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @NegiSushant , can you please fix the incorrect placement of the arrows ?
|
Mr-Sunglasses
requested changes
Jul 15, 2024
|
|
||
| </div> | ||
| ); | ||
| <div className="flex flex-wrap justify-center gap-4 mx-4 md:mx-20"> |
There was a problem hiding this comment.
You can use grid-cols-7 which allows for better control over the placement of the courses and arrows.
src/components/frontend.jsx
Outdated
| ); | ||
| <div className="flex flex-wrap justify-center gap-4 mx-4 md:mx-20"> | ||
| {courses.map((course, index) => ( | ||
| <div key={index}> |
There was a problem hiding this comment.
You can also use React.Fragment to group each course with its corresponding arrow which can help ensure that the arrow is placed in the next grid column.
|
hey @Mr-Sunglasses ! I review my code and the result show me after change is: |
|
Yeah @NegiSushant It looks good, please push those changes :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the UI and maintainability of the frontend Roadmap component. The changes include:
These changes make the component easier to manage, more responsive, and visually appealing.
This PR fixes #291