Run PHPStan against FOSSBilling source #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelleNottelling
changed the title
And remove the php_version on like 35-36 since we don't need it.
admdly
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the CI workflow to run PHPStan against the module and both the dev version of FOSSBilling and the latest release. This makes it easier to quickly check at least a base level compatibility for both the current and upcoming releases.
The "preview" check is failing as expected, as the code for this module is incompatible with our current dev branch (and as such, FOSSBilling version 0.5.0 once it's released).
The workflow uses the latest version of PHP, as FOSSBilling should always be supporting that. This means we shouldn't need to update the workflow when we change the supported versions for FOSSBilling.
If all seems well, this can ideally become a template workflow for module developers to check low-level compatibility with their module & get PHPStan feedback,
I also made a few minor fixes to the other workflows.