Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment upload grading #833

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

adityacp
Copy link
Contributor

@adityacp adityacp commented Apr 8, 2021

  • Add a separate URL in code server to get file urls and download it in the student directory.
  • Add a celery task to send all question files at once to the code server at the start of the quiz instead of sending the files during evaluation.
  • Change assignment file urls instead of absolute path to the code server for evaluation.
  • Fix issue while deleting the Lesson file.

@pep8speaks
Copy link

pep8speaks commented Apr 8, 2021

Hello @adityacp! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 209:80: E501 line too long (91 > 79 characters)

Line 95:1: W391 blank line at end of file

Comment last updated at 2021-04-26 05:20:53 UTC

- Fix R and Python evaluation tests
- Add return to the celery task to store the task result in the database
@codecov-commenter
Copy link

Codecov Report

Merging #833 (5ed0f0a) into master (4756f86) will decrease coverage by 0.38%.
The diff coverage is 43.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   76.69%   76.30%   -0.39%     
==========================================
  Files          53       53              
  Lines        7684     7761      +77     
  Branches     1166     1177      +11     
==========================================
+ Hits         5893     5922      +29     
- Misses       1408     1453      +45     
- Partials      383      386       +3     
Impacted Files Coverage Δ
yaksh/code_server.py 78.26% <25.00%> (-6.99%) ⬇️
yaksh/file_utils.py 64.38% <39.13%> (-12.09%) ⬇️
yaksh/models.py 85.08% <41.66%> (-0.10%) ⬇️
yaksh/tasks.py 72.85% <43.47%> (-5.78%) ⬇️
yaksh/hook_evaluator.py 74.00% <50.00%> (-4.85%) ⬇️
yaksh/views.py 70.67% <60.00%> (+0.07%) ⬆️
api/views.py 75.83% <100.00%> (-0.91%) ⬇️
yaksh/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53b86c...5ed0f0a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants