-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging #16
Conversation
… version to config. cleaning utils module, removing unused functions.
…ass with dataclass, replacing time and coord utils with astropy.
…ucturing classes. Moving profile class as seperate module with new boxcar template methods.
…ose of subclassing ndarrays, so reverting. More rigid Header class. Added tests and new data for header class.
…s. Also added more tests.
…ng previous changes.
Holy cow that is quite the refactor! 🕳️ 🐮 🕳️ |
Hi @telegraphic, the major change is in the |
Hi @telegraphic, I am going ahead with the refactoring. The plan is to make this package an entirely python-based replacement of This will break the existing API. So, moving the current code to a legacy branch. |
Glorious work! Python only seems reasonable, but bit unpacking might be difficult? BTW, I suggest tagging a release & updating the README.md 🚀 |
bit unpacking powered by numpy/numba. 1 bit ( Yes, need to update README. |
Refactoring of the whole package.
io module
io
module now. Removing theback_compatible
option and usingsigproc_keys
(defined in sigproc docs) as the definition of a sigproc header.Header
Header
structure. The aim is to have a common header class read from different formats sigproc/psrfits/inf and write back. The header class is now more rigid compared to the earlier version, with property attributes handled accordingly.C++
libcpp
module.other
FilterbankBlock
to a separate module.FoldedData
is nowfoldedcube.
Renaming theFilterbank
module tobase
(all readers should inherit from this base class).spp_header
andspp_decimate
for now).