-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot Configuration Manager #8
Comments
I rewrote |
I think it's something we need to discuss for sure because there are many ways to do it. One way would be to use a JSON file to store the configurations and then just read the correct configuration. We could have "global" configurations for stuff that is not specific to a robot in particular (such as controller mappings) and then "local" configurations for robot-dependent settings. I'll try and quickly write something to show you what I mean. We could also do it using constants but I think that would be a little messier. Since this is going to be used a lot I feel like it's important that we get it right. |
It would be cool if the configurations could be changed on the fly, from networktables or something. This would have to be done while disabled, but for things like fine-tuning PID or trying out different control schemes it could be useful to be able to change the settings so rapidly. |
Another question, do the variables need to be constants? As in what's wrong with having them as methods? Is it just less easy to do |
Team Decision: We're going to use |
Fluid constantsWe've decided on a couple of requirements for the fluid constants.
|
In reference to #8 Was not entirely sure of how to implement the fluid constants system. The best solution to me seems to be using object, which is a little annoying given the memory issues we've had but this is a relatively small number of objects each containing a small amount of data. The other ways that I thought of were quite messy and would involve a lot of work, which would go against the requirements of the issue this is trying to solve. If you could take a look at this @eandr127 before I continue and make sure that this is an approach that works for you, that would be good. If you wanted to access a constant, say the `OPERATOR_PRESS_A` constant, you would do `Config.OPERATOR_PRESS_A.getValue()` in total.
Guys, I'm impressed! |
The fluid constants system has been tested to be functional to the specifications laid out in #8. Not the nicest code yet, but that will change.
We need to have some sort of method for easily accessing robot configurations, such as the button mappings for controllers as well as robot-dependent variables.
This is kind of like a merge between RobotConfig and RobotMap from last year.
The frontend portion of this needs to be easy to use.
The text was updated successfully, but these errors were encountered: