Emily bottom arm #25
Open
Emily bottom arm #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizhang-2706
approved these changes
Nov 23, 2023
ErikCald
reviewed
Nov 28, 2023
| if (SubsystemChecker.canSubsystemConstruct(SubsystemType.ArmSubsystem)) { | ||
| System.out.println("*****robotInit*****"); | ||
| new WaitCommand(5).andThen(new SyncArmEncoders()).schedule(); | ||
| //new WaitCommand(10).andThen(new CheckArmEncodersSync()).schedule(); |
There was a problem hiding this comment.
Both commands require the ArmSubsystem and one of them is cancelling the other.
This will detach the requirement from the WaitCommand(10):
new WaitCommand(10).andThen(new ScheduleCommand(new CheckArmEncodersSync())).schedule();
There was a problem hiding this comment.
added that line, it works
weizhang-2706
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished bottom arm functionality- can be set to 90 and 80 degrees