Skip to content

Commit

Permalink
ConfigData->feature() confirms that modules actually load
Browse files Browse the repository at this point in the history
Closes RT#43557


git-svn-id: http://svn.perl.org/modules/Module-Build/trunk@12865 50811bd7-b8ce-0310-adc1-d9db26280581
  • Loading branch information
xdg committed Jun 19, 2009
1 parent 832d81f commit c3d3dbe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Revision history for Perl extension Module::Build.

Bug-fixes:
- Removes Module::Build from its own configure/build_requires
- ConfigData->feature() confirms that modules actually load successfully,
not just that they are present. (RT#43557)

Other
- On MSWin32, bumped File::Spec prereq to 3.30 for a variety of fixes
Expand Down
1 change: 1 addition & 0 deletions lib/Module/Build/Notes.pm
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ sub feature {
while (my ($modname, $spec) = each %%p) {
my $status = Module::Build->check_installed_status($modname, $spec);
if ((!$status->{ok}) xor ($type =~ /conflicts$/)) { return 0; }
if ( ! eval "require $modname; 1" ) { return 0; }
}
}
return 1;
Expand Down

0 comments on commit c3d3dbe

Please sign in to comment.