bgpd: simplify lookup list call with fs pbr entries

no test is done to check for validity of fs_pbr and fs_iprule pointer. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
FRRouting · Mar 29, 2019 · e0c7edb · e0c7edb
1 parent 2fe55af
commit e0c7edb
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/bgpd/bgp_pbr.c b/bgpd/bgp_pbr.c
@@ -2067,9 +2067,9 @@ static void bgp_pbr_policyroute_add_to_zebra_unit(struct bgp *bgp,
 			struct bgp_path_info_extra *extra =
 				bgp_path_info_extra_get(path);
 
-			if (extra && extra->bgp_fs_iprule &&
-			    listnode_lookup(extra->bgp_fs_iprule,
-						     bpr)) {
+			if (extra &&
+			    listnode_lookup_nocheck(extra->bgp_fs_iprule,
+						    bpr)) {
 				if (BGP_DEBUG(pbr, PBR_ERROR))
 					zlog_err("%s: entry %p/%p already "
 						 "installed in bgp pbr iprule",
@@ -2216,8 +2216,8 @@ static void bgp_pbr_policyroute_add_to_zebra_unit(struct bgp *bgp,
 		struct bgp_path_info_extra *extra =
 			bgp_path_info_extra_get(path);
 
-		if (extra && extra->bgp_fs_pbr &&
-		    listnode_lookup(extra->bgp_fs_pbr, bpme)) {
+		if (extra &&
+		    listnode_lookup_nocheck(extra->bgp_fs_pbr, bpme)) {
 			if (BGP_DEBUG(pbr, PBR_ERROR))
 				zlog_err(
 					"%s: entry %p/%p already installed in bgp pbr",