eigrp: multiple Error type: validation #11301

c-po · 2022-05-29T09:39:55Z

Did you check if this is a duplicate issue?
Did you test it on the latest FRRouting/frr master branch?

To Reproduce

LR1.wue3(config)# router eigrp 100
LR1.wue3(config-router)# passive-interface eth0
% Configuration failed.

Error type: validation
LR1.wue3(config-router)# passive-interface eth1
% Configuration failed.

Error type: validation

LR1.wue3(config)# interface eth0
LR1.wue3(config-if)# eigrp bandwidth 10
% Configuration failed.

Expected behavior

No config error

Screenshots

Versions

OS Version: Debian 11 (VyOS 1.4)

Kernel: 5.10.117

FRR Version: 8.2.2 commit 56694ea

Additional context

The text was updated successfully, but these errors were encountered:

volodymyrhuti · 2022-05-31T10:00:05Z

I have triaged down this issue:

The error has appeared between frr-7.1 and frr-7.2 when migrating to the northbound

vova | git log -1 f25c244b7
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
commit f25c244b7502f2fa61f143b514eef8f6b9e24355 ┃
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━
Author: Rafael Zalamena <rzalamena@opensourcerouting.org>
Date:   Tue Jul 30 12:44:13 2019 -0300

    eigrpd: migrate old CLI to northbound
    
    Move all configuration commands to the new CLI code (`eigrp_cli.c`),
    implement the northbound and do all the necessary wiring to get it
    working.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

The new architecture introduces a validation step that fails

тра 31 02:02:16 Zephyrus eigrpd[935768]: [EC 100663331] nb_callback_configuration: error processing configuration change: error [internal inconsistency] event [validate] operation [create] xpath [/frr-eigrpd:eigrpd/instance[asn='100'][vrf='']/passive-interface[.='eth1']]
тра 31 02:02:16 Zephyrus eigrpd[935768]: [EC 100663337] nb_candidate_commit_prepare: failed to validate candidate configuration

May 31 09:40:32 vyos eigrpd[5758]: [MHYBZ-5A04C][EC 100663334] error processing configuration change: error [internal inconsistency] event [validate] operation [modify] xpath [/frr-interface:lib/interface[name='eth0']/frr-eigrpd:eigrp/bandwidth]
May 31 09:40:32 vyos eigrpd[5758]: [H68KZ-12QEF][EC 100663340] nb_candidate_commit_prepare: failed to validate candidate configuration

frr/eigrpd/eigrpd_northboud.c:
---------------------------------------------------------------------------------------
/*
 * XPath: /frr-eigrpd:eigrpd/instance/passive-interface
 */
static int
eigrpd_instance_passive_interface_create(struct nb_cb_create_args *args)
{
	struct eigrp_interface *eif;
	struct eigrp *eigrp;
	const char *ifname;

	switch (args->event) {
	case NB_EV_VALIDATE:
		eigrp = nb_running_get_entry(args->dnode, NULL, false);
		if (eigrp == NULL) {
			/*
			 * XXX: we can't verify if the interface exists
			 * and is active until EIGRP is up.
			 */
			break;
		}

		ifname = yang_dnode_get_string(args->dnode, NULL);
		eif = eigrp_interface_lookup(eigrp, ifname);       

		#### ERR: failed validation, interface list empty
		if (eif == NULL) 
		        #### ERR: configuration is inconsistent, return error
			return NB_ERR_INCONSISTENCY; 
		break;



---------------------------------------------------------------------------------------
Prior implementation
frr/eigrpd/eigrpd_northboud.c:
---------------------------------------------------------------------------------------
DEFUN (eigrp_passive_interface,
       eigrp_passive_interface_cmd,
       "passive-interface IFNAME",
       "Suppress routing updates on an interface\n"
       "Interface to suppress on\n")
{
	VTY_DECLVAR_CONTEXT(eigrp, eigrp);
	struct eigrp_interface *ei;
	struct listnode *node;
	char *ifname = argv[1]->arg;

	for (ALL_LIST_ELEMENTS_RO(eigrp->eiflist, node, ei)) {
		if (strcmp(ifname, ei->ifp->name) == 0) {
			ei->params.passive_interface = EIGRP_IF_PASSIVE;
			return CMD_SUCCESS;
		}
	}
	return CMD_SUCCESS;                                                                       
}

From the testing, I can see that when executing the provided configuration, the eiflist is empty both for
pre/post 7.2 versions. Looking at the old logic, nothing is done if the list is empty, but success is still returned.

The next step is to look through the interface initialization logic and consider the proper configuration flow.
I will look for a solution once I have a moment (a bit later ;)

tarunkundu-est · 2022-10-04T17:54:35Z

Hi @volodymyrhuti - Did you get a chance to look through the interface initialization logic? I am also seeing this "Configuration failed" issue for every eigrp cli command in FRR 7.5.1 release.

volodymyrhuti · 2023-03-06T05:40:25Z

Hi all! Here is a short update on the issue:

I have retested on the latest frr build, and the issue is still valid; the steps are following

ZephyrusNG# configure terminal 
ZephyrusNG(config)# router eigrp 1
ZephyrusNG(config-router)# passive-interface 
docker0     enp5s0      lo          mpqemubr0   virbr0      virbr0-nic  wlp4s0      
ZephyrusNG(config-router)# passive-interface wlp4s0 
% Configuration failed.

Error type: validation

I have checked the topotest topology: topotests/eigrp_topo1/test_eigrp_topo1.py
Using passive-interface for an active interface (with converged topology) works without issue

os.environ["PYTHONBREAKPOINT"] = "pudb.set_trace"
def test_converge_protocols():
    "Wait for protocol convergence"

    tgen = get_topogen()
    # Don't run this test if we have any failure.
    if tgen.routers_have_failure():
        pytest.skip(tgen.errors)

    topotest.sleep(5, "Waiting for EIGRP convergence")
    breakpoint()

------------
ZephyrusNG# show interface 
Interface lo is up, line protocol is up
  Link ups:       0    last: (never)
  Link downs:     0    last: (never)
  vrf: default
  index 1 metric 0 mtu 65536 speed 0 
  flags: <UP,LOOPBACK,RUNNING>
  Ignore all v6 routes with linkdown
  Type: Loopback
  inet6 fe80::200:ff:fe00:0/64
  Interface Type Other
  Interface Slave Type None
  protodown: off 
Interface r1-eth0 is up, line protocol is up
  Link ups:       0    last: (never)
  Link downs:     0    last: (never)
  vrf: default
  index 2 metric 0 mtu 1500 speed 10000 
  flags: <UP,BROADCAST,RUNNING,MULTICAST>
  Ignore all v6 routes with linkdown
  Type: Ethernet
  HWaddr: 12:31:9c:1f:c3:99
  inet 192.168.1.1/24
  inet6 fe80::1031:9cff:fe1f:c399/64
  Interface Type VETH
  Interface Slave Type None
  protodown: off 
  Parent interface: r1-eth1
Interface r1-eth1 is up, line protocol detection is disabled
  Link ups:       0    last: (never)
  Link downs:     0    last: (never)
  vrf: default
  Description: to sw2 - RIPv2 interface
  index 3 metric 0 mtu 1500 speed 10000 
  flags: <UP,BROADCAST,RUNNING,MULTICAST>
  Ignore all v6 routes with linkdown
  Type: Ethernet
  HWaddr: ca:5b:e3:89:ff:35
  inet 193.1.1.1/26
  inet6 fe80::c85b:e3ff:fe89:ff35/64
  Interface Type VETH
  Interface Slave Type None
  protodown: off 
  Parent ifindex: 5
ZephyrusNG# configure terminal 
ZephyrusNG(config)# router eigrp 1
ZephyrusNG(config-router)# 
root@ZephyrusNG:/tmp/topotests/eigrp_topo1.test_eigrp_topo1# vtysh

Hello, this is FRRouting (version 9.0-dev).
Copyright 1996-2005 Kunihiro Ishiguro, et al.

ZephyrusNG# show run
Building configuration...

Current configuration:
!
frr version 9.0-dev
frr defaults traditional
hostname r1
log file /tmp/topotests/eigrp_topo1.test_eigrp_topo1/r1/zebra.log
log timestamp precision 3
log commands
log file /tmp/topotests/eigrp_topo1.test_eigrp_topo1/r1/eigrpd.log
log file /tmp/topotests/eigrp_topo1.test_eigrp_topo1/r1/staticd.log
hostname ZephyrusNG
no service integrated-vtysh-config
!
interface r1-eth0
 ip address 192.168.1.1/24
exit
!
interface r1-eth1
 description to sw2 - RIPv2 interface
 ip address 193.1.1.1/26
 no link-detect
exit
!
router eigrp 1
 network 0.0.0.0/0
exit
!
end
ZephyrusNG# configure terminal 
ZephyrusNG(config)# router eigrp 1
ZephyrusNG(config-router)# passive-interface 
lo       r1-eth0  r1-eth1  
ZephyrusNG(config-router)# passive-interface r1-eth0 
ZephyrusNG(config-router)# 
ZephyrusNG(config)# interface 
lo       r1-eth0  r1-eth1  
ZephyrusNG(config)# interface r1-eth0 
ZephyrusNG(config-if)# eigrp bandwidth 10
ZephyrusNG(config-if)#

XXX: Need to fix the handling/validation flow ??

github-actions · 2023-09-07T01:43:49Z

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

frrbot · 2023-09-07T01:43:52Z

This issue will be automatically closed in the specified period unless there is further activity.

volodymyrhuti · 2023-10-09T15:40:38Z

Hi all! Sorry for the delay, I couldn't find time for this (
This bug is still relevant, so I have detected two separate issues here:

Interfaces are not allocated unless topology converges, assuming a network command was issued.
Looking at similar daemons, I have noticed that ripd is solving this by maintaining a vector.
This means a separate mapping [iface_name -> iface_passive] and a couple more N.B. callbacks.
I have pulled this logic into eigrpd and published it via the following branch:
https://github.com/volodymyrhuti/frr/tree/EIGRP_BUG_NB_11301
Then I noticed the bandwidth failing with the same message, which sucks a lot.
From my research, I have found a commented-out callback that should initialize the iface structure.
eigrp_interface.c -> eigrp_if_init() -> // hook_register_prio(if_add, 0, eigrp_if_new);
Implementing it back should fix the config issue and will likely resolve the prior bug.
P.S. It doesn't fix the prior issue, assuming you want interface-passive default functionality
However, from testing, it breaks code semantics - allocation is not expected by the rest of the code.
I'm going to see if I can find semantics divergence, but I'm not sure how long it may take ;(

Instatiate interface structure once demon is started. Otherwise it is not possible to set parameters such as bandwidth untill a `network` configuration was applied. Fixes: FRRouting#11301 Signed-off-by: Volodymyr Huti <v.huti@vyos.io>

Maintain a vector of mappings [if_name -> if_passive]. Otherwise, if topo is not already convereged, configuration does not apply, since iface is missing from the iface list. Fixes: FRRouting#11301 Signed-off-by: Volodymyr Huti <v.huti@vyos.io>

Instatiate interface structure once demon is started. Otherwise it is not possible to set parameters such as bandwidth untill a `network` configuration was applied. Fixes: FRRouting#11301 Signed-off-by: Volodymyr Huti <v.huti@vyos.io>

Maintain a vector of mappings [if_name -> if_passive]. Otherwise, if topo is not already convereged, configuration does not apply, since iface is missing from the iface list. Fixes: FRRouting#11301 Signed-off-by: Volodymyr Huti <v.huti@vyos.io>

c-po added the triage Needs further investigation label May 29, 2022

github-actions bot added the autoclose label Sep 7, 2023

frrbot bot closed this as completed Sep 14, 2023

frrbot bot removed autoclose labels Sep 14, 2023

volodymyrhuti mentioned this issue Nov 9, 2023

Eigrp #11301 - Configuration failed error type: validation #14765

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eigrp: multiple Error type: validation #11301

eigrp: multiple Error type: validation #11301

c-po commented May 29, 2022

volodymyrhuti commented May 31, 2022

tarunkundu-est commented Oct 4, 2022

volodymyrhuti commented Mar 6, 2023 •

edited

github-actions bot commented Sep 7, 2023

frrbot bot commented Sep 7, 2023

volodymyrhuti commented Oct 9, 2023 •

edited

eigrp: multiple Error type: validation #11301

eigrp: multiple Error type: validation #11301

Comments

c-po commented May 29, 2022

volodymyrhuti commented May 31, 2022

tarunkundu-est commented Oct 4, 2022

volodymyrhuti commented Mar 6, 2023 • edited

github-actions bot commented Sep 7, 2023

frrbot bot commented Sep 7, 2023

volodymyrhuti commented Oct 9, 2023 • edited

volodymyrhuti commented Mar 6, 2023 •

edited

volodymyrhuti commented Oct 9, 2023 •

edited