Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Add BGP configuration start/end markers #10838

Conversation

ton31337
Copy link
Member

Closes #10756

@frrbot frrbot bot added the bgp label Mar 21, 2022
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Mar 21, 2022

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-4270/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgpd.h | 2 issues
===============================================
< ERROR: "foo * bar" should be "foo *bar"
< #774: FILE: /tmp/f1-18493/bgpd.h:774:
Report for bgp_vty.c | 6 issues
===============================================
< ERROR: "foo * bar" should be "foo *bar"
< #17602: FILE: /tmp/f1-18493/bgp_vty.c:17602:
< WARNING: Block comments use a trailing */ on a separate line
< #17631: FILE: /tmp/f1-18493/bgp_vty.c:17631:
< WARNING: Block comments use a trailing */ on a separate line
< #17649: FILE: /tmp/f1-18493/bgp_vty.c:17649:

@Jafaral
Copy link
Member

Jafaral commented Mar 22, 2022

@Mergifyio backport stable/8.2

@mergify
Copy link

mergify bot commented Mar 22, 2022

backport stable/8.2

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Delay BGP configuration until we receive end-configuration hook to make sure
we don't send partial updates to peer which leads to broken Graceful-Restart.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337 ton31337 force-pushed the feature/bgpd_callbacks_for_start_end_configurations branch from 531e219 to aa24a36 Compare March 22, 2022 07:04
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-4275/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@pushpasis pushpasis self-assigned this Mar 22, 2022
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks correct ...

@riw777 riw777 merged commit 4037154 into FRRouting:master Mar 29, 2022
@ton31337 ton31337 deleted the feature/bgpd_callbacks_for_start_end_configurations branch March 29, 2022 15:31
@mergify
Copy link

mergify bot commented Mar 29, 2022

backport stable/8.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR fails due to bgp route-map delay-timer behavior
5 participants