isisd: fix show isis database [detail] json #11906

louis-6wind · 2022-09-05T14:02:42Z

Fixes for show isis database [detail] json

Clean JSON format.
Display multiple values into array. They were mixed together in the same dict.

NetDEF-CI · 2022-09-05T14:18:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10363: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10695: isisd/libfabric_a-isis_tlvs.o] Error 1

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/F29BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10364: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U2004AMD64BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c:2018:7: error: variable 'array_json' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
isisd/isis_tlvs.c:2022:25: note: uninitialized use occurs here
isisd/isis_tlvs.c:2018:3: note: remove the 'if' if its condition is always true
isisd/isis_tlvs.c:2016:44: note: initialize the variable 'array_json' to silence this warning
1 error generated.
gmake[1]: *** [Makefile:10366: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c:2018:7: error: variable 'array_json' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI011BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI021BUILD/config.log/config.log.gz

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/REDHAT8/config.log/config.log.gz

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10363: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10695: isisd/libfabric_a-isis_tlvs.o] Error 1

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/REDHAT8/config.status/config.status

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/RH9BUILD/config.log/config.log.gz

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10364: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/RH9BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10364: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10696: isisd/libfabric_a-isis_tlvs.o] Error 1

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB10BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10366: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI009BUILD/config.log/config.log.gz

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U22AMD64BUILD/config.status/config.status

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10367: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);

Ubuntu 22.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U22AMD64BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804AMD64/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10367: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10367: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10699: isisd/libfabric_a-isis_tlvs.o] Error 1

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI012BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1604I386/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10363: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10695: isisd/libfabric_a-isis_tlvs.o] Error 1

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/FBSD12AMD64/config.log/config.log.gz

Successful on other platforms/tests

CentOS 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10363: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10695: isisd/libfabric_a-isis_tlvs.o] Error 1

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/F29BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10364: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U2004AMD64BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c:2018:7: error: variable 'array_json' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
isisd/isis_tlvs.c:2022:25: note: uninitialized use occurs here
isisd/isis_tlvs.c:2018:3: note: remove the 'if' if its condition is always true
isisd/isis_tlvs.c:2016:44: note: initialize the variable 'array_json' to silence this warning
1 error generated.
gmake[1]: *** [Makefile:10366: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c:2018:7: error: variable 'array_json' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI011BUILD/config.status/config.status
OpenBSD 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI011BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI021BUILD/config.log/config.log.gz

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/REDHAT8/config.log/config.log.gz

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10363: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10695: isisd/libfabric_a-isis_tlvs.o] Error 1

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/REDHAT8/config.status/config.status

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/RH9BUILD/config.log/config.log.gz

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10364: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/RH9BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10364: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10696: isisd/libfabric_a-isis_tlvs.o] Error 1

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB10BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10366: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI009BUILD/config.log/config.log.gz

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U22AMD64BUILD/config.status/config.status

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10367: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:17: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |                 json_object_array_add(array_json, old_json);

Ubuntu 22.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U22AMD64BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1804AMD64/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10367: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2022 |   json_object_array_add(array_json, old_json);

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

NetBSD 9 amd64 build: Failed (click for details)

NetBSD 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10367: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10699: isisd/libfabric_a-isis_tlvs.o] Error 1

NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI012BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.7234/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:9700: recipe for target 'isisd/isis_tlvs.o' failed
make[1]: *** [isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function format_item_oldstyle_ip_reach:
isisd/isis_tlvs.c:2022:3: error: array_json may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/U1604I386/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.7234/frr-source'
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10363: isisd/isis_tlvs.o] Error 1
isisd/isis_tlvs.c: In function 'format_item_oldstyle_ip_reach':
isisd/isis_tlvs.c:2022:3: error: 'array_json' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10695: isisd/libfabric_a-isis_tlvs.o] Error 1

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7234/artifact/FBSD12AMD64/config.log/config.log.gz

Report for isisd.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #2678: FILE: /tmp/f1-13720/isisd.c:2678:
< WARNING: line over 80 characters
< #2734: FILE: /tmp/f1-13720/isisd.c:2734:
Report for isis_tlvs.c | 16 issues
===============================================
< WARNING: line over 80 characters
< #1873: FILE: /tmp/f1-13720/isis_tlvs.c:1873:
< WARNING: line over 80 characters
< #2420: FILE: /tmp/f1-13720/isis_tlvs.c:2420:
< WARNING: line over 80 characters
< #2582: FILE: /tmp/f1-13720/isis_tlvs.c:2582:
< WARNING: line over 80 characters
< #2584: FILE: /tmp/f1-13720/isis_tlvs.c:2584:
< WARNING: line over 80 characters
< #2594: FILE: /tmp/f1-13720/isis_tlvs.c:2594:
< WARNING: line over 80 characters
< #2601: FILE: /tmp/f1-13720/isis_tlvs.c:2601:
< WARNING: line over 80 characters
< #3217: FILE: /tmp/f1-13720/isis_tlvs.c:3217:
< WARNING: line over 80 characters
< #3239: FILE: /tmp/f1-13720/isis_tlvs.c:3239:

NetDEF-CI · 2022-09-05T17:23:43Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7239/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2022-09-05T17:29:41Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7238/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for isisd.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2735: FILE: /tmp/f1-15434/isisd.c:2735:
Report for isis_tlvs.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #2425: FILE: /tmp/f1-15434/isis_tlvs.c:2425:
< WARNING: line over 80 characters
< #2590: FILE: /tmp/f1-15434/isis_tlvs.c:2590:
< WARNING: line over 80 characters
< #2600: FILE: /tmp/f1-15434/isis_tlvs.c:2600:
< WARNING: line over 80 characters
< #2607: FILE: /tmp/f1-15434/isis_tlvs.c:2607:
< WARNING: line over 80 characters
< #3246: FILE: /tmp/f1-15434/isis_tlvs.c:3246:

ton31337

Just some comments about backward compatibility and JSON key naming.

ton31337 · 2022-09-06T05:54:54Z

isisd/isis_tlvs.c

@@ -494,36 +494,36 @@ static void format_item_ext_subtlvs(struct isis_ext_subtlvs *exts,
 						    adj->sid);
 				json_object_int_add(flags_json, "weight",
 						    adj->weight);
-				json_object_string_add(
+				json_object_boolean_add(


Technically this is correct, but should we keep both formats (1/0, true/false) for a deprecation cycle?

Honestly, the JSON output of this command was not usable because the information was wrong.
For example, "show isis database json" was mixing info of all routers in a single object {}.
Even with a single router "show isis database RTR json", information was not in the right place. If multiple TLVs
were present, only the last one was displayed but sometimes with data from the previous ones.

I think it is not useful to have a deprecation cycle.

ton31337 · 2022-09-06T05:56:08Z

isisd/isis_tlvs.c

+		}
+		json_object_array_add(array_json, old_json);
+		json_object_object_add(json, "is-reach", old_json);
+		json_object_string_add(old_json, "is-neighbor",


Is this the specific TLV name or can be anything? If anything, then let's do not follow old naming and use as it should be correctly (e.g.:: isNeighbor).

ton31337 · 2022-09-06T05:56:56Z

isisd/isis_tlvs.c

 		old_json = json_object_new_object();
-		json_object_object_add(json, "old-ip-reach-style", old_json);


Are we breaking backward compatibility here?

The command was not working before

ton31337 · 2022-09-06T05:57:13Z

isisd/isis_tlvs.c

 		json_object_int_add(mt_json, "mtid", info->mtid);
+		json_object_string_add(mt_json, "mt-description",


Ditto, regarding JSON key naming.

riw777

I think the places where @ton31337 has pointed out backward compatibility problems need to be addressed ... otherwise the code looks fine

louis-6wind · 2022-12-15T17:11:58Z

I think the places where @ton31337 has pointed out backward compatibility problems need to be addressed ... otherwise the code looks fine

The command was not working so we can consider there is no backward compatibility problems

NetDEF-CI · 2022-12-15T17:45:22Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8912/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: No useful log found

Successful on other platforms/tests

Ubuntu 16.04 i386 build
CentOS 7 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm7 build
FreeBSD 11 amd64 build
Debian 11 amd64 build
Redhat 9 amd64 build
Ubuntu 16.04 amd64 build
Redhat 8 amd64 build
OpenBSD 7 amd64 build
FreeBSD 12 amd64 build
Fedora 29 amd64 build
Ubuntu 22.04 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Debian 10 amd64 build
Ubuntu 16.04 arm7 build

NetDEF-CI · 2022-12-15T21:06:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8910/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-8910/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8910/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8910/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-8910/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8910/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8910/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-8910/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8910/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
Fedora 29 rpm pkg check
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Static analyzer (clang)

Information about the routers in lsdb are mixed in the same json as if it was about the same router. Display all values in an array. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Display information about a particular router in show isis database in an single value array for compatibility with the display of all routers. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Multiple occurrences of the same (sub-)TLVs are mixed into a single JSON object. Last values replaces the previous. Display all the occurrences in an array for the following (sub-)TLVs: - is-reach - ip-reach - ext-reach - ext-ip-reach - ipv6-reach - MT - prefix-SID Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Some keys are wrongly displayed at the JSON parent level. Add the key at the current level. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Only the MT ID is displayed. Display the MT description as well. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

When a level is not present in show isis database detail json, {} is displayed. Display nothing for non present level. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

Display booleans values with string such as "", "*", "yes" and "no" are not correct on JSON. Display boolean values as true or false. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

JSON keys should not contain '-'. For example, "flag-v" is incorrect and should be "flagV". Rename JSON keys in "show isis database detail json" that contains '-' or '_'. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

{"mtRouterInfo": "none"} JSON is incorrect. Change to {"mtRouterInfo": null} Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

NetDEF-CI · 2022-12-20T19:28:56Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8990/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 11906, comparing to Git base SHA 43203ba

No Changes in Static Analysis warnings compared to base

2 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-8990/artifact/shared/static_analysis/index.html

github-actions · 2023-02-15T08:44:24Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-08-15T01:43:24Z

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

frrbot bot added bugfix isis labels Sep 5, 2022

github-actions bot added the master label Sep 5, 2022

louis-6wind force-pushed the show_isis_db_json branch 2 times, most recently from 183cbc6 to 795be31 Compare September 5, 2022 15:05

ton31337 reviewed Sep 6, 2022

View reviewed changes

riw777 reviewed Sep 6, 2022

View reviewed changes

eqvinox self-requested a review September 6, 2022 15:23

louis-6wind force-pushed the show_isis_db_json branch from 795be31 to c5ccb09 Compare December 15, 2022 17:01

github-actions bot added the size/L label Dec 15, 2022

louis-6wind force-pushed the show_isis_db_json branch from c5ccb09 to 313be35 Compare December 15, 2022 17:13

louis-6wind added 9 commits December 20, 2022 17:31

isisd: fix keys display in show isis database detail json

e50b4ac

Some keys are wrongly displayed at the JSON parent level. Add the key at the current level. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

isisd: display MT name in show isis database detail json

c40cacf

Only the MT ID is displayed. Display the MT description as well. Fixes: a2cac12 ("isisd: Add json to show isis database command.") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

isisd: fix null display is show isis database detail json

b2fcdaa

{"mtRouterInfo": "none"} JSON is incorrect. Change to {"mtRouterInfo": null} Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

louis-6wind force-pushed the show_isis_db_json branch from 313be35 to b2fcdaa Compare December 20, 2022 17:10

github-actions bot added the conflicts label Feb 15, 2023

github-actions bot added the autoclose label Aug 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

isisd: fix show isis database [detail] json #11906

isisd: fix show isis database [detail] json #11906

louis-6wind commented Sep 5, 2022

NetDEF-CI commented Sep 5, 2022 •

edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Sep 5, 2022 •

edited

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Sep 5, 2022 •

edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

ton31337 left a comment

ton31337 Sep 6, 2022

louis-6wind Sep 6, 2022

ton31337 Sep 6, 2022

louis-6wind Dec 15, 2022

ton31337 Sep 6, 2022

louis-6wind Dec 15, 2022

ton31337 Sep 6, 2022

louis-6wind Dec 15, 2022

riw777 left a comment

louis-6wind commented Dec 15, 2022

NetDEF-CI commented Dec 15, 2022 •

edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Dec 15, 2022 •

edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Dec 20, 2022

github-actions bot commented Feb 15, 2023

github-actions bot commented Aug 15, 2023

		old_json = json_object_new_object();
		json_object_object_add(json, "old-ip-reach-style", old_json);

		json_object_int_add(mt_json, "mtid", info->mtid);
		json_object_string_add(mt_json, "mt-description",

isisd: fix show isis database [detail] json #11906

Are you sure you want to change the base?

isisd: fix show isis database [detail] json #11906

Conversation

louis-6wind commented Sep 5, 2022

NetDEF-CI commented Sep 5, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Sep 5, 2022 • edited

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Sep 5, 2022 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

ton31337 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riw777 left a comment

Choose a reason for hiding this comment

louis-6wind commented Dec 15, 2022

NetDEF-CI commented Dec 15, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Dec 15, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Dec 20, 2022

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

2 Static Analyzer issues remaining.

github-actions bot commented Feb 15, 2023

github-actions bot commented Aug 15, 2023

NetDEF-CI commented Sep 5, 2022 •

edited

NetDEF-CI commented Sep 5, 2022 •

edited

NetDEF-CI commented Sep 5, 2022 •

edited

NetDEF-CI commented Dec 15, 2022 •

edited

NetDEF-CI commented Dec 15, 2022 •

edited