Don't disable redirected files when running in daemon mode. Also add topotest flag to report memory allocations on exit logged to stderr #12050

louberger · 2022-10-03T00:35:12Z

This restores the ability to catch memory free/cleanup errors on exit without running valgrind. This used to work and was broken sometime in the last year or so by multiple changes.

This also includes minor doc changes and an ubuntu 22.04 doc

NetDEF-CI · 2022-10-03T01:08:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Successful on other platforms/tests

Ubuntu 18.04 ppc64le build
NetBSD 9 amd64 build
FreeBSD 12 amd64 build
Fedora 29 amd64 build
Debian 11 amd64 build
Ubuntu 18.04 arm7 build
Ubuntu 18.04 arm8 build
OpenBSD 7 amd64 build
Ubuntu 16.04 arm7 build
FreeBSD 11 amd64 build
Ubuntu 22.04 amd64 build
Ubuntu 16.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7672/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Report for libfrr.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1187: FILE: /tmp/f1-2795712/libfrr.c:1187:

mwinter-osr · 2022-10-03T08:32:25Z

CI:rerun Previous failures from CI maintenance. Rerunning

NetDEF-CI · 2022-10-03T10:45:23Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 i386 part 3: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-7680/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-7680/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-7680/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-7680/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-7680/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-7680/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-7680/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO7U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-7680/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-7680/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7680/artifact/TOPO7DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 7
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2

NetDEF-CI · 2022-10-04T18:53:03Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-7717/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-7717/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-7717/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 5: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-7717/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO7DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Addresssanitizer topotests part 1: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-7717/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO7U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-7717/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Addresssanitizer topotests part 5: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-7717/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-7717/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-7717/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7717/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 6
Static analyzer (clang)
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 2
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 2
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3

NetDEF-CI · 2022-10-07T22:29:23Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-7776/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO7U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-7776/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-7776/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 2: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-7776/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-7776/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-7776/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-7776/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-7776/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-7776/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7776/artifact/TOPO7DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Fedora 29 rpm pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 4

NetDEF-CI · 2022-10-10T18:59:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7812/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-7812/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7812/artifact/TOPO3U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 4
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 8
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-7812/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7812/artifact/TOPO3U18I386/ErrorLog/log_topotests.txt

Report for libfrr.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1187: FILE: /tmp/f1-2595900/libfrr.c:1187:

louberger · 2022-10-10T19:36:05Z

CI:rerun - failed test runs fine locally and reported failure not related to changes

NetDEF-CI · 2022-10-10T21:48:06Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7817/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 3: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 4
Debian 10 deb pkg check
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 i386 part 3
Debian 9 deb pkg check
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 5
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 9
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 8
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 8

louberger · 2022-10-11T11:31:04Z

CI:rerun - failure different from last, and still unrelated to change (looks like CI timing or startup issue)

NetDEF-CI · 2022-10-11T13:48:02Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7836/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for libfrr.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1187: FILE: /tmp/f1-2903138/libfrr.c:1187:

choppsv1 · 2022-10-13T16:04:38Z

doc/developer/building-frr-for-ubuntu2204.rst

@@ -0,0 +1,171 @@
+Ubuntu 20.04 LTS


Should this be 22.04?

yes, needs to be fixed

lib/libfrr.c

choppsv1 · 2022-10-13T16:14:12Z

lib/libfrr.c

-
-	have_leftovers = log_memstats(stderr, di->name);
+	/* also log memstats to stderr when stderr goes to a file*/
+	if (debug_memstats_at_exit || !isatty(2))


isatty(STDERR_FILENO) maybe makes things more obvious.

lib/libfrr.c

NetDEF-CI · 2022-10-16T14:38:19Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7913/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for libfrr.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1187: FILE: /tmp/f1-170513/libfrr.c:1187:

ton31337

Could you apply frrbot styling warnings?

eqvinox · 2022-11-01T15:28:56Z

I thought there already was some way in the logging subsystem to keep FDs open, in particular for --log stdout; lemme check where that was and why it's not covering this.

louberger · 2022-11-01T15:33:22Z

Look at the diff - you'll see this was not the case.

…

On 11/1/2022 11:29 AM, David Lamparter wrote: I thought there already was some way in the logging subsystem to keep FDs open, in particular for |--log stdout|; lemme check where that was and why it's not covering this. — Reply to this email directly, view it on GitHub <#12050 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSFNSHCHHDQUOEYFXQT4GTWGEZMHANCNFSM6AAAAAAQ3EHIRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

eqvinox · 2022-11-01T15:48:01Z

Look at the diff - you'll see this was not the case.

Indeed. Which means daemon -d --log stdout is broken too.

eqvinox

isatty() is the wrong thing to check here - need to check instead of stdout or stderr are a log target. (Actually only stdout can be a log target as of now, but, concept applies.)

Also the memstats should be written to the log, not stderr — there is absolutely no reason to special-case the memstats like that.

(Yes, the logging subsystem works without impact until process exit. I'm sure about that because I put in the work to make that true 😆)

eqvinox · 2022-11-01T15:51:05Z

lib/libfrr.c

+		int fd;
+		/* only redirect stdin, stdout, stderr to null when a tty */
+		for (fd = 2; fd >= 0; fd--)
+			if (isatty(fd))


isatty is not the right thing to do here, because daemon -d --log stdout should work too, including if stdout is in fact a TTY.

The check needs to be is fd X open as log target instead.

louberger · 2022-11-01T18:44:05Z

why? the code was always sent to dev null, with this change it only does it when NOT going to a log. Why would we want to redirect a log to /dev/null

…

On 11/1/2022 11:54 AM, David Lamparter wrote: ***@***.**** requested changes on this pull request. |isatty()| is the wrong thing to check here - need to check instead of |stdout| or |stderr| are a log target. (Actually only |stdout| can be a log target as of now, but, concept applies.) Also the memstats should be written to the log, not |stderr| — there is absolutely no reason to special-case the memstats like that. (Yes, the logging subsystem works without impact until process exit. I'm sure about that because I put in the work to make that true 😆) ------------------------------------------------------------------------ In lib/libfrr.c <#12050 (comment)>: > @@ -1101,9 +1101,11 @@ static void frr_terminal_close(int isexit) "%s: failed to open /dev/null: %s", __func__, safe_strerror(errno)); } else { - dup2(nullfd, 0); - dup2(nullfd, 1); - dup2(nullfd, 2); + int fd; + /* only redirect stdin, stdout, stderr to null when a tty */ + for (fd = 2; fd >= 0; fd--) + if (isatty(fd)) |isatty| is not the right thing to do here, because |daemon -d --log stdout| should work too, including if stdout is in fact a TTY. The check needs to be |is fd X open as log target| instead. — Reply to this email directly, view it on GitHub <#12050 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSFNSEHMTMWA7ZSK6OKSDTWGE4LLANCNFSM6AAAAAAQ3EHIRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

eqvinox · 2022-11-01T20:00:12Z

I'm not opposed to it being changed, I just thing that it's an independent change.

I was mostly thinking ahead since right now I think the only thing you can do is keep stdout and stderr open if --log stdout is used. There isn't really anything else to go by… debug memstats-at-exit or log stdout from config are processed too late, FDs are already closed at that point. Keeping stderr open if --log stdout is given feels… weird… (because different FD) and requiring --log stdout to get the memstats stderr output is no less weird…

eqvinox · 2022-11-01T20:01:35Z

But yeah let's take it one step at a time, moving the memstats over into regular logging is an independent TODO item

NetDEF-CI · 2022-11-01T23:06:50Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8168/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8168/artifact/TOPO9U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 5
CentOS 7 rpm pkg check
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8168/artifact/TOPO9U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 9: No useful log found

Report for libfrr.c | 14 issues
===============================================
< ERROR: do not initialise statics to false
< #146: FILE: /tmp/f1-3449929/libfrr.c:146:
< WARNING: Block comments use * on subsequent lines
< #756: FILE: /tmp/f1-3449929/libfrr.c:756:
< WARNING: Block comments use a trailing */ on a separate line
< #757: FILE: /tmp/f1-3449929/libfrr.c:757:
< ERROR: space prohibited after that '!' (ctx:ExW)
< #1116: FILE: /tmp/f1-3449929/libfrr.c:1116:
< WARNING: line over 80 characters
< #1196: FILE: /tmp/f1-3449929/libfrr.c:1196:
< WARNING: line over 80 characters
< #1197: FILE: /tmp/f1-3449929/libfrr.c:1197:
< ERROR: space prohibited after that '!' (ctx:ExW)
< #1201: FILE: /tmp/f1-3449929/libfrr.c:1201:

louberger · 2022-11-05T12:55:06Z

@eqvinox take a look - I believe I addressed the issue

louberger · 2022-11-05T12:56:42Z

CI:rerun -- failure due to ospf timing, not PR

NetDEF-CI · 2022-11-05T15:10:19Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8237/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for libfrr.c | 14 issues
===============================================
< ERROR: do not initialise statics to false
< #146: FILE: /tmp/f1-1076016/libfrr.c:146:
< WARNING: Block comments use * on subsequent lines
< #756: FILE: /tmp/f1-1076016/libfrr.c:756:
< WARNING: Block comments use a trailing */ on a separate line
< #757: FILE: /tmp/f1-1076016/libfrr.c:757:
< ERROR: space prohibited after that '!' (ctx:ExW)
< #1116: FILE: /tmp/f1-1076016/libfrr.c:1116:
< WARNING: line over 80 characters
< #1196: FILE: /tmp/f1-1076016/libfrr.c:1196:
< WARNING: line over 80 characters
< #1197: FILE: /tmp/f1-1076016/libfrr.c:1197:
< ERROR: space prohibited after that '!' (ctx:ExW)
< #1201: FILE: /tmp/f1-1076016/libfrr.c:1201:

eqvinox · 2022-11-28T10:23:32Z

sorry about the delay, getting back to this now

eqvinox · 2022-11-28T10:28:12Z

Ugh, it's pretty ugly now, but gimme a bit to form an opinion whether it's avoidable ugliness or not…

choppsv1 · 2023-04-01T19:44:41Z

Ugh, it's pretty ugly now, but gimme a bit to form an opinion whether it's avoidable ugliness or not…

@eqvinox This is useful functionality, can you clear the change request so it can move forward?

github-actions · 2023-04-22T23:59:29Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Lou Berger <lberger@labn.net>

… null when a tty. Also write memstat to stderr when stderr is not a tty and allow for --log stdout Signed-off-by: Lou Berger <lberger@labn.net>

Signed-off-by: Lou Berger <lberger@labn.net>

…on variable Signed-off-by: Lou Berger <lberger@labn.net>

choppsv1 · 2023-05-11T11:49:57Z

@eqvinox please clear your change request.

NetDEF-CI · 2023-05-11T14:14:56Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11486/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11486/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 7
Debian 10 deb pkg check
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11486/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for libfrr.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #133: FILE: /tmp/f1-4137631/libfrr.c:133:
< WARNING: Block comments use * on subsequent lines
< #743: FILE: /tmp/f1-4137631/libfrr.c:743:
< WARNING: Block comments use a trailing */ on a separate line
< #744: FILE: /tmp/f1-4137631/libfrr.c:744:

NetDEF-CI · 2023-05-11T14:18:36Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11489/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11489/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 3
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 9
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Static analyzer (clang)
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11489/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for libfrr.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #133: FILE: /tmp/f1-4182087/libfrr.c:133:
< WARNING: Block comments use * on subsequent lines
< #743: FILE: /tmp/f1-4182087/libfrr.c:743:
< WARNING: Block comments use a trailing */ on a separate line
< #744: FILE: /tmp/f1-4182087/libfrr.c:744:

NetDEF-CI · 2023-05-11T16:27:02Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11489/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for libfrr.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #133: FILE: /tmp/f1-4182087/libfrr.c:133:
< WARNING: Block comments use * on subsequent lines
< #743: FILE: /tmp/f1-4182087/libfrr.c:743:
< WARNING: Block comments use a trailing */ on a separate line
< #744: FILE: /tmp/f1-4182087/libfrr.c:744:

Jafaral · 2023-05-11T18:49:45Z

@eqvinox any further comments here?

outdated

louberger requested a review from donaldsharp October 3, 2022 00:35

frrbot bot added bugfix documentation libfrr labels Oct 3, 2022

github-actions bot added the master label Oct 3, 2022

louberger force-pushed the working/lb/topotest-220909 branch from 57d2955 to de272d2 Compare October 4, 2022 16:40

louberger force-pushed the working/lb/topotest-220909 branch from de272d2 to ab4a7d1 Compare October 7, 2022 20:15

louberger force-pushed the working/lb/topotest-220909 branch from ab4a7d1 to 07f62a0 Compare October 10, 2022 16:46

choppsv1 reviewed Oct 13, 2022

View reviewed changes

louberger force-pushed the working/lb/topotest-220909 branch from 07f62a0 to d816201 Compare October 16, 2022 12:25

choppsv1 self-requested a review October 17, 2022 19:52

choppsv1 approved these changes Oct 18, 2022

View reviewed changes

ton31337 reviewed Oct 20, 2022

View reviewed changes

eqvinox self-requested a review November 1, 2022 15:26

eqvinox previously requested changes Nov 1, 2022

View reviewed changes

louberger force-pushed the working/lb/topotest-220909 branch from d816201 to 4d63aa1 Compare November 1, 2022 20:52

github-actions bot added the conflicts label Apr 22, 2023

louberger added 2 commits May 11, 2023 07:13

doc: update for ubuntu 22.04 and to run topotest with valgrind

39869a3

Signed-off-by: Lou Berger <lberger@labn.net>

lib: when running as a daemon, only redirect sdtin, stdout, sdterr to…

4d28aea

… null when a tty. Also write memstat to stderr when stderr is not a tty and allow for --log stdout Signed-off-by: Lou Berger <lberger@labn.net>

choppsv1 force-pushed the working/lb/topotest-220909 branch from 4d63aa1 to abd02c1 Compare May 11, 2023 11:43

github-actions bot added size/L and removed conflicts labels May 11, 2023

louberger added 3 commits May 11, 2023 07:46

topotests: fix looging of memstat results

c668655

Signed-off-by: Lou Berger <lberger@labn.net>

topotest: add --memleaks topotest option

d497770

Signed-off-by: Lou Berger <lberger@labn.net>

topotest: all_protocol_startup - respect TOPOTESTS_CHECK_STDERR envir…

083d367

…on variable Signed-off-by: Lou Berger <lberger@labn.net>

choppsv1 force-pushed the working/lb/topotest-220909 branch from abd02c1 to 083d367 Compare May 11, 2023 11:46

Jafaral approved these changes May 11, 2023

View reviewed changes

eqvinox merged commit cf0eeb3 into FRRouting:master May 16, 2023
6 checks passed

eqvinox deleted the working/lb/topotest-220909 branch May 16, 2023 06:31

Don't disable redirected files when running in daemon mode. Also add topotest flag to report memory allocations on exit logged to stderr #12050

Don't disable redirected files when running in daemon mode. Also add topotest flag to report memory allocations on exit logged to stderr #12050

Conversation

louberger commented Oct 3, 2022

NetDEF-CI commented Oct 3, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

mwinter-osr commented Oct 3, 2022

NetDEF-CI commented Oct 3, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Oct 4, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Oct 7, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Oct 10, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

louberger commented Oct 10, 2022

NetDEF-CI commented Oct 10, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

louberger commented Oct 11, 2022

NetDEF-CI commented Oct 11, 2022 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

choppsv1 Oct 13, 2022

Choose a reason for hiding this comment

louberger Oct 16, 2022

Choose a reason for hiding this comment

choppsv1 Oct 13, 2022

Choose a reason for hiding this comment

louberger Oct 16, 2022

Choose a reason for hiding this comment

NetDEF-CI commented Oct 16, 2022 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

ton31337 left a comment

Choose a reason for hiding this comment

eqvinox commented Nov 1, 2022

louberger commented Nov 1, 2022 via email

eqvinox commented Nov 1, 2022

eqvinox left a comment

Choose a reason for hiding this comment

eqvinox Nov 1, 2022

Choose a reason for hiding this comment

louberger commented Nov 1, 2022 via email

eqvinox commented Nov 1, 2022 • edited

eqvinox commented Nov 1, 2022

NetDEF-CI commented Nov 1, 2022 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

louberger commented Nov 5, 2022

louberger commented Nov 5, 2022

NetDEF-CI commented Nov 5, 2022 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

eqvinox commented Nov 28, 2022

eqvinox commented Nov 28, 2022

choppsv1 commented Apr 1, 2023 • edited

github-actions bot commented Apr 22, 2023

choppsv1 commented May 11, 2023

NetDEF-CI commented Oct 3, 2022 •

edited

NetDEF-CI commented Oct 3, 2022 •

edited

NetDEF-CI commented Oct 4, 2022 •

edited

NetDEF-CI commented Oct 7, 2022 •

edited

NetDEF-CI commented Oct 10, 2022 •

edited

NetDEF-CI commented Oct 10, 2022 •

edited

NetDEF-CI commented Oct 11, 2022 •

edited

NetDEF-CI commented Oct 16, 2022 •

edited

eqvinox commented Nov 1, 2022 •

edited

NetDEF-CI commented Nov 1, 2022 •

edited

NetDEF-CI commented Nov 5, 2022 •

edited

choppsv1 commented Apr 1, 2023 •

edited