Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evpn zebra stuff #12346

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

donaldsharp
Copy link
Member

See individual commits. Effectively some internal changes that should be upstreamed.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Nov 19, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.8430/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8430/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6223: all] Error 2
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:66:1: internal compiler error: Segmentation fault
0x7f15898f7d5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7f158939f32d type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.8430/frr-source/tools/gcc-plugins/frr-format.c:2703
0x7f158939fa50 check_format_types
	/home/ci/cibuild.8430/frr-source/tools/gcc-plugins/frr-format.c:2879

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI012BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8430/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8430/frr-source/doc/user/nexthop_groups.rst
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10215: zebra/zebra_evpn_arp_nd.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17759: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI012BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8430/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.8430/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6223: all] Error 2
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8430/frr-source'
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10211: zebra/zebra_evpn_arp_nd.o] Error 1
/usr/home/ci/cibuild.8430/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8430/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8430/frr-source'
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 16.04 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.8430/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8430/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6223: all] Error 2
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:66:1: internal compiler error: Segmentation fault
0x7f15898f7d5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7f158939f32d type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.8430/frr-source/tools/gcc-plugins/frr-format.c:2703
0x7f158939fa50 check_format_types
	/home/ci/cibuild.8430/frr-source/tools/gcc-plugins/frr-format.c:2879

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI012BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8430/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8430/frr-source/doc/user/nexthop_groups.rst
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10215: zebra/zebra_evpn_arp_nd.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17759: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI012BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8430/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.8430/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6223: all] Error 2
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8430/frr-source'
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10211: zebra/zebra_evpn_arp_nd.o] Error 1
/usr/home/ci/cibuild.8430/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8430/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8430/frr-source'
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32:0,
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_vxlan_encap:
./lib/zlog.h:120:20: error: format %lu expects argument of type long unsigned int, but argument 3 has type unsigned int [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/zebra_evpn_arp_nd.c:186:3: note: in expansion of macro zlog_debug
cc1: all warnings being treated as errors
Makefile:9545: recipe for target 'zebra/zebra_evpn_arp_nd.o' failed
make[1]: *** [zebra/zebra_evpn_arp_nd.o] Error 1

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8430/artifact/U18I386BUILD/config.log/config.log.gz

Report for if_packet.h | 18 issues
===============================================
< WARNING: please, no space before tabs
< #29: FILE: /tmp/f1-1259926/if_packet.h:29:
< WARNING: line over 80 characters
< #113: FILE: /tmp/f1-1259926/if_packet.h:113:
< WARNING: line over 80 characters
< #115: FILE: /tmp/f1-1259926/if_packet.h:115:
< WARNING: line over 80 characters
< #143: FILE: /tmp/f1-1259926/if_packet.h:143:
< WARNING: line over 80 characters
< #144: FILE: /tmp/f1-1259926/if_packet.h:144:
< WARNING: line over 80 characters
< #249: FILE: /tmp/f1-1259926/if_packet.h:249:
< WARNING: line over 80 characters
< #250: FILE: /tmp/f1-1259926/if_packet.h:250:
< WARNING: Block comments use * on subsequent lines
< #259: FILE: /tmp/f1-1259926/if_packet.h:259:
< WARNING: line over 80 characters
< #265: FILE: /tmp/f1-1259926/if_packet.h:265:
Report for interface.h | 4 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #183: FILE: /tmp/f1-1259926/interface.h:183:
< WARNING: Block comments use a trailing */ on a separate line
< #212: FILE: /tmp/f1-1259926/interface.h:212:
Report for zebra_evpn_arp_nd.c | 20 issues
===============================================
WARNING: externs should be avoided in .c files
#45: FILE: /tmp/f1-1259926/zebra_evpn_arp_nd.c:45:
+extern struct zebra_privs_t zserv_privs;

WARNING: Block comments use a trailing */ on a separate line
#287: FILE: /tmp/f1-1259926/zebra_evpn_arp_nd.c:287:
+	 * redirect the traffic to */

WARNING: Block comments use a trailing */ on a separate line
#641: FILE: /tmp/f1-1259926/zebra_evpn_arp_nd.c:641:
+	 * packets */

WARNING: Block comments use a trailing */ on a separate line
#645: FILE: /tmp/f1-1259926/zebra_evpn_arp_nd.c:645:
+	 * snooping on them */

WARNING: Block comments use a trailing */ on a separate line
#659: FILE: /tmp/f1-1259926/zebra_evpn_arp_nd.c:659:
+	 * snooping on them */
Report for zebra_evpn_arp_nd.h | 4 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#59: FILE: /tmp/f1-1259926/zebra_evpn_arp_nd.h:59:
+	 * XXX - use this to optimize packet parsing if needed */

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Nov 19, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:66:1: internal compiler error: Segmentation fault
0x7fbaf2c3cd5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7fbaf26e432d type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.8433/frr-source/tools/gcc-plugins/frr-format.c:2703
0x7fbaf26e4a50 check_format_types
	/home/ci/cibuild.8433/frr-source/tools/gcc-plugins/frr-format.c:2879

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI012BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8433/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8433/frr-source/doc/user/nexthop_groups.rst
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10215: zebra/zebra_evpn_arp_nd.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17759: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI012BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8433/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.8433/frr-source'
gmake: *** [Makefile:6223: all] Error 2
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8433/frr-source'
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10211: zebra/zebra_evpn_arp_nd.o] Error 1
/usr/home/ci/cibuild.8433/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8433/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8433/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.8433/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8433/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6223: all] Error 2
Successful on other platforms/tests
  • Ubuntu 18.04 i386 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm8 build
  • Redhat 8 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Debian 10 amd64 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 16.04 arm7 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:66:1: internal compiler error: Segmentation fault
0x7fbaf2c3cd5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7fbaf26e432d type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.8433/frr-source/tools/gcc-plugins/frr-format.c:2703
0x7fbaf26e4a50 check_format_types
	/home/ci/cibuild.8433/frr-source/tools/gcc-plugins/frr-format.c:2879

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI012BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8433/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8433/frr-source/doc/user/nexthop_groups.rst
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10215: zebra/zebra_evpn_arp_nd.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17759: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI012BUILD/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.8433/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.8433/frr-source'
gmake: *** [Makefile:6223: all] Error 2
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8433/frr-source'
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10211: zebra/zebra_evpn_arp_nd.o] Error 1
/usr/home/ci/cibuild.8433/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8433/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8433/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8433/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.8433/frr-source/doc/user/zebra.rst:752: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10214: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8433/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6223: all] Error 2
Report for if_packet.h | 18 issues
===============================================
< WARNING: please, no space before tabs
< #29: FILE: /tmp/f1-3587249/if_packet.h:29:
< WARNING: line over 80 characters
< #113: FILE: /tmp/f1-3587249/if_packet.h:113:
< WARNING: line over 80 characters
< #115: FILE: /tmp/f1-3587249/if_packet.h:115:
< WARNING: line over 80 characters
< #143: FILE: /tmp/f1-3587249/if_packet.h:143:
< WARNING: line over 80 characters
< #144: FILE: /tmp/f1-3587249/if_packet.h:144:
< WARNING: line over 80 characters
< #249: FILE: /tmp/f1-3587249/if_packet.h:249:
< WARNING: line over 80 characters
< #250: FILE: /tmp/f1-3587249/if_packet.h:250:
< WARNING: Block comments use * on subsequent lines
< #259: FILE: /tmp/f1-3587249/if_packet.h:259:
< WARNING: line over 80 characters
< #265: FILE: /tmp/f1-3587249/if_packet.h:265:
Report for interface.h | 4 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #183: FILE: /tmp/f1-3587249/interface.h:183:
< WARNING: Block comments use a trailing */ on a separate line
< #212: FILE: /tmp/f1-3587249/interface.h:212:
Report for zebra_evpn_arp_nd.c | 24 issues
===============================================
WARNING: externs should be avoided in .c files
#45: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.c:45:
+extern struct zebra_privs_t zserv_privs;

WARNING: type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
#188: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.c:188:
+			(long unsigned int)(len + sizeof(struct vxlanhdr)),

WARNING: Block comments use a trailing */ on a separate line
#287: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.c:287:
+	 * redirect the traffic to */

WARNING: Block comments use a trailing */ on a separate line
#641: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.c:641:
+	 * packets */

WARNING: Block comments use a trailing */ on a separate line
#645: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.c:645:
+	 * snooping on them */

WARNING: Block comments use a trailing */ on a separate line
#659: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.c:659:
+	 * snooping on them */
Report for zebra_evpn_arp_nd.h | 4 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#59: FILE: /tmp/f1-3587249/zebra_evpn_arp_nd.h:59:
+	 * XXX - use this to optimize packet parsing if needed */

"show evpn arp-nd-redirect[json]",
SHOW_STR
"EVPN\n"
"ARP/NA packet redirect\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARP/ND?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was intentional I believe. So I'm not going to change it.

}

if (uj) {
vty_out(vty, "%s\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vty_json()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

return -1;
}

if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (void *)&reuse,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Suggest reusing sock_set_reuse().

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sock_set_reuse is a ldpd specific function? I'm not really sure what you are advocating here?

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Mar 23, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.10350/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10480: zebra/zebra_evpn_arp_nd.o] Error 1
ospfd/ospf_vty.c: In function 'show_ip_ospf_neighbour_brief':
ospfd/ospf_vty.c:4411:3: note: '#pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter'
 4411 |   CPP_NOTICE(
gmake[1]: Leaving directory '/usr/home/ci/cibuild.10350/frr-source'
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:66:1: internal compiler error: Segmentation fault
0x7fb12bf11d5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7fb12b9bc32d type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.10350/frr-source/tools/gcc-plugins/frr-format.c:2689
0x7fb12b9bca50 check_format_types
	/home/ci/cibuild.10350/frr-source/tools/gcc-plugins/frr-format.c:2865

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/DEB11AMD64/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10350/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10480: zebra/zebra_evpn_arp_nd.o] Error 1
ospfd/ospf_vty.c:4411:3: warning: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter [-W#pragma-messages]
./lib/compiler.h:214:26: note: expanded from macro 'CPP_NOTICE'
#define CPP_NOTICE(text) _Pragma(CPP_STR(message text))
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.10350/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10477: zebra/zebra_evpn_arp_nd.o] Error 1
ospfd/ospf_vty.c: In function 'show_ip_ospf_neighbour_brief':
ospfd/ospf_vty.c:4411:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
gmake[1]: Leaving directory '/usr/home/ci/cibuild.10350/frr-source'
Successful on other platforms/tests
  • Ubuntu 16.04 arm7 build
  • Ubuntu 18.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 i386 build
  • Redhat 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 16.04 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.10350/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10480: zebra/zebra_evpn_arp_nd.o] Error 1
ospfd/ospf_vty.c: In function 'show_ip_ospf_neighbour_brief':
ospfd/ospf_vty.c:4411:3: note: '#pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter'
 4411 |   CPP_NOTICE(
gmake[1]: Leaving directory '/usr/home/ci/cibuild.10350/frr-source'
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:66:1: internal compiler error: Segmentation fault
0x7fb12bf11d5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7fb12b9bc32d type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.10350/frr-source/tools/gcc-plugins/frr-format.c:2689
0x7fb12b9bca50 check_format_types
	/home/ci/cibuild.10350/frr-source/tools/gcc-plugins/frr-format.c:2865

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/DEB11AMD64/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.10350/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10480: zebra/zebra_evpn_arp_nd.o] Error 1
ospfd/ospf_vty.c:4411:3: warning: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter [-W#pragma-messages]
./lib/compiler.h:214:26: note: expanded from macro 'CPP_NOTICE'
#define CPP_NOTICE(text) _Pragma(CPP_STR(message text))
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10350/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.10350/frr-source/doc/user/affinitymap.rst: WARNING: document isn't included in any toctree
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10477: zebra/zebra_evpn_arp_nd.o] Error 1
ospfd/ospf_vty.c: In function 'show_ip_ospf_neighbour_brief':
ospfd/ospf_vty.c:4411:3: note: #pragma message: Remove show_ip_ospf_neighbor_sub() JSON keys: priority, state, deadTimeMsecs, address, retransmitCounter, requestCounter, dbSummaryCounter
gmake[1]: Leaving directory '/usr/home/ci/cibuild.10350/frr-source'
Report for if_packet.h | 18 issues
===============================================
< WARNING: please, no space before tabs
< #29: FILE: /tmp/f1-2347056/if_packet.h:29:
< WARNING: line over 80 characters
< #113: FILE: /tmp/f1-2347056/if_packet.h:113:
< WARNING: line over 80 characters
< #115: FILE: /tmp/f1-2347056/if_packet.h:115:
< WARNING: line over 80 characters
< #143: FILE: /tmp/f1-2347056/if_packet.h:143:
< WARNING: line over 80 characters
< #144: FILE: /tmp/f1-2347056/if_packet.h:144:
< WARNING: line over 80 characters
< #249: FILE: /tmp/f1-2347056/if_packet.h:249:
< WARNING: line over 80 characters
< #250: FILE: /tmp/f1-2347056/if_packet.h:250:
< WARNING: Block comments use * on subsequent lines
< #259: FILE: /tmp/f1-2347056/if_packet.h:259:
< WARNING: line over 80 characters
< #265: FILE: /tmp/f1-2347056/if_packet.h:265:
Report for interface.h | 4 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #172: FILE: /tmp/f1-2347056/interface.h:172:
< WARNING: Block comments use a trailing */ on a separate line
< #201: FILE: /tmp/f1-2347056/interface.h:201:
Report for zebra_evpn_arp_nd.c | 24 issues
===============================================
WARNING: externs should be avoided in .c files
#45: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.c:45:
+extern struct zebra_privs_t zserv_privs;

WARNING: type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
#184: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.c:184:
+			(long unsigned int)(len + sizeof(struct vxlanhdr)),

WARNING: Block comments use a trailing */ on a separate line
#283: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.c:283:
+	 * redirect the traffic to */

WARNING: Block comments use a trailing */ on a separate line
#636: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.c:636:
+	 * packets */

WARNING: Block comments use a trailing */ on a separate line
#640: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.c:640:
+	 * snooping on them */

WARNING: Block comments use a trailing */ on a separate line
#654: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.c:654:
+	 * snooping on them */
Report for zebra_evpn_arp_nd.h | 4 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#59: FILE: /tmp/f1-2347056/zebra_evpn_arp_nd.h:59:
+	 * XXX - use this to optimize packet parsing if needed */

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14020/frr-source/doc/user/zebra.rst:843: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10562: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.14020/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6442: all] Error 2
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.14020/frr-source/doc/user/zebra.rst:843: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10562: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.14020/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6442: all] Error 2
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.14020/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.14020/frr-source/doc/user/nexthop_groups.rst
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10559: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.14020/frr-source'
gmake: *** [Makefile:6439: all] Error 2
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:65:1: internal compiler error: Segmentation fault
0x7f67057cdd5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7f67052792ca type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.14020/frr-source/tools/gcc-plugins/frr-format.c:2689
0x7f67052799ed check_format_types
	/home/ci/cibuild.14020/frr-source/tools/gcc-plugins/frr-format.c:2865

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • Debian 9 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14020/frr-source/doc/user/zebra.rst:843: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: 'asm/byteorder.h' file not found
#include <asm/byteorder.h>
1 error generated.
gmake[1]: *** [Makefile:10562: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.14020/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6442: all] Error 2
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.14020/frr-source/doc/user/zebra.rst:843: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
In file included from zebra/zebra_evpn_arp_nd.c:22:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10562: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.14020/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6442: all] Error 2
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.14020/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.14020/frr-source/doc/user/nexthop_groups.rst
In file included from zebra/zebra_evpn_arp_nd.c:22:0:
./include/linux/if_packet.h:5:10: fatal error: asm/byteorder.h: No such file or directory
 #include <asm/byteorder.h>
compilation terminated.
gmake[1]: *** [Makefile:10559: zebra/zebra_evpn_arp_nd.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.14020/frr-source'
gmake: *** [Makefile:6439: all] Error 2
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/DEB11AMD64/ErrorLog/log_make.txt)

PLUGIN_PRAGMAS                   | frr-format
zebra/zebra_evpn_arp_nd.c: In function zebra_evpn_arp_nd_pkt_dump:
zebra/zebra_evpn_arp_nd.c:65:1: internal compiler error: Segmentation fault
0x7f67057cdd5f ???
	./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7f67052792ca type_normalize(tree_node*, tree_node**, tree_node*)
	/home/ci/cibuild.14020/frr-source/tools/gcc-plugins/frr-format.c:2689
0x7f67052799ed check_format_types
	/home/ci/cibuild.14020/frr-source/tools/gcc-plugins/frr-format.c:2865

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14020/artifact/DEB11AMD64/config.status/config.status

Report for if_packet.h | 6 issues
===============================================
< WARNING: Improper SPDX comment style for '/tmp/f1-1909850/if_packet.h', please use '//' instead
< #1: FILE: /tmp/f1-1909850/if_packet.h:1:
< WARNING: please, no space before tabs
< #29: FILE: /tmp/f1-1909850/if_packet.h:29:
< WARNING: Block comments use * on subsequent lines
< #259: FILE: /tmp/f1-1909850/if_packet.h:259:
Report for interface.h | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #202: FILE: /tmp/f1-1909850/interface.h:202:
Report for zebra_evpn_arp_nd.c | 32 issues
===============================================
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:1:
+/*

WARNING: externs should be avoided in .c files
#45: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:45:
+extern struct zebra_privs_t zserv_privs;

WARNING: type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order
#181: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:181:
+			   (long unsigned int)(len + sizeof(struct vxlanhdr)),

WARNING: Prefer 'unsigned long' over 'long unsigned int' as the int is unnecessary
#181: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:181:
+			   (long unsigned int)(len + sizeof(struct vxlanhdr)),

WARNING: Block comments use a trailing */ on a separate line
#276: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:276:
+	 * redirect the traffic to */

WARNING: Block comments use a trailing */ on a separate line
#624: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:624:
+	 * packets */

WARNING: Block comments use a trailing */ on a separate line
#628: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:628:
+	 * snooping on them */

WARNING: Block comments use a trailing */ on a separate line
#642: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.c:642:
+	 * snooping on them */
Report for zebra_evpn_arp_nd.h | 8 issues
===============================================
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.h:1:
+/*

WARNING: Block comments use a trailing */ on a separate line
#59: FILE: /tmp/f1-1909850/zebra_evpn_arp_nd.h:59:
+	 * XXX - use this to optimize packet parsing if needed */

AnuradhaKaruppiah and others added 4 commits November 8, 2023 12:56
Add PVID to the bridge-port entry. This info is needed for arp-na
packet redirection in EVPN multihoming.

Ticket: CM-30135

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
…n MH

If multihoming is enabled with fast-failover we need need to redirect
unicast ARP-replies and Neighbor-Advertisements in user space if the
DMAC points to an operationally down ES.

If fast failover is enabled we expect the dataplane (ASIC) to redirect
traffic headed to the down-ES via the VxLAN overlay. However ARP packets
on bridge access members are not forwarded by the ASIC. They are sent to
the CPU to be forwarded by the kernel post ARP suppression decisions.
Currently the kernel does not handle fast-failover (traffic redirection).
So we need to workaround that limitation in user space.

We do the user-space redirection currently in zebra as it has all the
necessary databases (VLAN->VNI mapping, MAC/FDB and ES tables). A raw
socket is created for every bridge-access port if MH is enabled (on
addition of first local ES). This socket listens on ARP-replies and
NAs. A read thread is also created per-bridge-access-port to read and
redirect these packets via the VxLAN overlay (vxlan encapsulates and
sends) if needed.

Use case example:
1. H11 and H12 are multi-homed to L11 and L12.
2. Say link between L12<=>H12 is down.
3. H12 sends a ARP request to H11.
4. H11 replies via the link attached to L12.
5. L12 rxes the packet and finds the DMAC (H12) via an ES that is
oper-down.
6. L12 (zebra) redirects the packet via (the VxLAN overlay) L11 to H12.

Sample output:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
torm-11# sh evpn arp-nd-redirect
EVPN ARP-reply/NA redirect: enabled
Stats:
  IPv4 ARP replies: 11
  IPv6 neighbor advertisements: 538
  Redirected packets: 9
  Skipped packets:    Not ready: 0
    VNI missing: 0
    MAC missing: 25
    Dest is not local ES: 513
    Dest ES oper-up: 2
torm-11#
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

Ticket: CM-30135

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
Delete the packet threads and sockets before database cleanup.

Ticket: CM-31197

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants