yang: route-distinguisher typedef for route-maps reworked #12385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated results 🚧Basic BGPD CI results: Partial FAILURE, 1 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8554/ This is a comment from an automated CI system. |
ton31337
reviewed
Nov 25, 2022
| typedef route-distinguisher { | ||
| type string { | ||
| pattern | ||
| '(0:(6553[0-5]|655[0-2][0-9]|65[0-4][0-9]{2}|' |
There was a problem hiding this comment.
The question is: is this maintainable overall? 😄
There was a problem hiding this comment.
I am not yang expert enough to know if I can make inheritance between typedefs.
What I just do is to enlarge the regexp, hoping that one day, the ietf will follow. :)
pguibert6WIND
force-pushed
the
rd_yang_enlarge
branch
from
31f52d4
to
e271bb0
Compare
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO6U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-8578/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-8578/test Topology Tests failed for Topotests debian 10 amd64 part 8 Ubuntu 20.04 deb pkg check: Failed (click for details)Ubuntu 20.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/U20DEBPKG/ErrorLog/log_package_start.txt Ubuntu 20.04 deb pkg check: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundDebian 10 deb pkg check: Failed (click for details)Debian 10 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/DEB10PKGCHK/ErrorLog/log_package_start.txt Debian 10 deb pkg check: No useful log foundTopotests debian 10 amd64 part 3: Failed (click for details)Topotests debian 10 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO3DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 3: No useful log foundTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-8578/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4 Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 3: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-8578/test Topology Tests failed for Topotests debian 10 amd64 part 4 Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO3U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 3: No useful log foundDebian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO9U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO9U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 9: No useful log foundUbuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundTopotests debian 10 amd64 part 1: Failed (click for details)Topotests debian 10 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO1DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO6U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-8578/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8 Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO1U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 1: No useful log foundTopotests debian 10 amd64 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2DEB10AMD64-8578/test Topology Tests failed for Topotests debian 10 amd64 part 2 Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-8578/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0: see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-8578/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4 Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-8578/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-8578/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Topotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO6DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-8578/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5 Fedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundTopotests debian 10 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-8578/test Topology Tests failed for Topotests debian 10 amd64 part 5 Topotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-8578/test Topology Tests failed for Topotests debian 10 amd64 part 0 Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18ARM8-8578/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 2: see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundAddresssanitizer topotests part 9: Incomplete(check logs for details)Addresssanitizer topotests part 8: Incomplete(check logs for details)CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TOPO9DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TP3U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 3: No useful log foundTopotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-8578/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7 Topotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18I386-8578/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 2 Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/TP1U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-8578/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5 Ubuntu 18.04 deb pkg check: Failed (click for details)Ubuntu 18.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8578/artifact/U18DEBPKG/ErrorLog/log_package_start.txt Ubuntu 18.04 deb pkg check: No useful log foundTopotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-8578/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP2U1804AMD64-8578/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 2 Topotests debian 10 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-8578/test Topology Tests failed for Topotests debian 10 amd64 part 7 Successful on other platforms/tests
|
Some route-distinguisher combinations were not possible under
route-maps:
route-map rmap permit 1
match evpn rd 65540:44
match evpn rd 1.2.3.4:44
match evpn rd 2000000:44
Do not use the ietf definition for route-distinguisher by overriding
a new definition in bgp-route-map.yang itself. When the BGP northbound
API will be done, this route-distinguisher definition will have to
be used too.
Fixes: ("48cb7ea99d10") bgpd: North-bound implementation for bgp rmaps
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
rd_yang_enlarge
branch
from
e271bb0
to
909f274
Compare
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8630/ This is a comment from an automated CI system. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some route-distinguisher combinations were not possible under route-maps:
route-map rmap permit 1
match evpn rd 65540:44
match evpn rd 1.2.3.4:44
match evpn rd 2000000:44
Do not use the ietf definition for route-distinguisher by overriding a new definition in bgp-route-map.yang itself. When the BGP northbound API will be done, this route-distinguisher definition will have to be used too.
Fixes: ("48cb7ea99d10") bgpd: North-bound implementation for bgp rmaps
Signed-off-by: Philippe Guibert philippe.guibert@6wind.com