pimd: stop KATs on one interface #12451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8710/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8710/artifact/TOPO8U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8710/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
anlancs
force-pushed
the
fix/pimd-stop-kat
branch
from
e43cc8f
to
e60e8f8
Compare
anlancs
changed the title
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8714/artifact/TOPO8U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8714/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8714/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8733/artifact/TOPO8U18ARM64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8733/artifact/TOPO8U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8733/artifact/TOPO8DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 8: No useful log foundSuccessful on other platforms/tests
|
|
It seems the CI is failing due to your changes. rerun wont fix it. Please check. |
Since FRRouting#10569 is a workaround for FRRouting#10782, this PR continues: Immediately stop KATs on the interface if this interface is down or not pim-enabled. Signed-off-by: anlan_cs <vic.lan@pica8.com>
anlancs
force-pushed
the
fix/pimd-stop-kat
branch
from
e60e8f8
to
86d4161
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8754/artifact/TOPO9U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun for ospf failed |
|
ci:rerun for ospf failed again |
|
ci:rerun why |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8777/ This is a comment from an automated CI system. |
|
@mobash-rasool Happy to see CI passed, please review it. Thanks. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8775/ This is a comment from an automated CI system. |
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
|
@anlancs : The issue which you were trying to fix here is closed(fixed) in another way. Can we close this PR? |
|
@mobash-rasool I forgot details on it. But i have tested latest code just now, after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #10569 is a workaround for #10782, this PR continues:
Immediately stop KATs on the interface if this interface is down or not
pim-enabled.