Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oper state #14492

Merged
merged 25 commits into from Dec 29, 2023
Merged

oper state #14492

merged 25 commits into from Dec 29, 2023

Conversation

choppsv1
Copy link
Contributor

No description provided.

@frrbot frrbot bot added documentation libfrr ospf tests Topotests, make check, etc yang labels Sep 26, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 26, 2023 •
edited

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14342/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-14342/artifact/CHECKOUT/ErrorLog/log_merge.txt

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 26, 2023 •
edited

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.14343/frr-source'
In file included from lib/mgmt_msg.c:16:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:66:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:77:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
3 errors generated.
gmake[1]: *** [Makefile:10645: lib/mgmt_msg.lo] Error 1
In file included from lib/mgmt_msg_native.c:9:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14343/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14343/frr-source/doc/user/nexthop_groups.rst
lib/vty.c: In function vty_mgmt_get_tree_result_notified:
lib/vty.c:3863:8: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
cc1: all warnings being treated as errors
Makefile:9945: recipe for target 'lib/vty.lo' failed
make[1]: *** [lib/vty.lo] Error 1
make[1]: Leaving directory '/home/ci/cibuild.14343/frr-source'
make[1]: Target 'all-am' not remade because of errors.
Makefile:5788: recipe for target 'all' failed

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14343/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14343/frr-source/doc/user/nexthop_groups.rst
lib/vty.c: In function vty_mgmt_get_tree_result_notified:
lib/vty.c:3863:8: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
cc1: all warnings being treated as errors
Makefile:9945: recipe for target 'lib/vty.lo' failed
make[1]: *** [lib/vty.lo] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.14343/frr-source'
Makefile:5788: recipe for target 'all' failed
Successful on other platforms/tests
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • CentOS 7 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 22.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Redhat 9 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 11 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.14343/frr-source'
In file included from lib/mgmt_msg.c:16:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:66:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:77:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
3 errors generated.
gmake[1]: *** [Makefile:10645: lib/mgmt_msg.lo] Error 1
In file included from lib/mgmt_msg_native.c:9:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14343/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14343/frr-source/doc/user/nexthop_groups.rst
lib/vty.c: In function vty_mgmt_get_tree_result_notified:
lib/vty.c:3863:8: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
cc1: all warnings being treated as errors
Makefile:9945: recipe for target 'lib/vty.lo' failed
make[1]: *** [lib/vty.lo] Error 1
make[1]: Leaving directory '/home/ci/cibuild.14343/frr-source'
make[1]: Target 'all-am' not remade because of errors.
Makefile:5788: recipe for target 'all' failed

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14343/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14343/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14343/frr-source/doc/user/nexthop_groups.rst
lib/vty.c: In function vty_mgmt_get_tree_result_notified:
lib/vty.c:3863:8: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
cc1: all warnings being treated as errors
Makefile:9945: recipe for target 'lib/vty.lo' failed
make[1]: *** [lib/vty.lo] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.14343/frr-source'
Makefile:5788: recipe for target 'all' failed

Report for mgmt_be_adapter.c | 8 issues
===============================================
< WARNING: static const char * array should probably be static const char * const
< #46: FILE: /tmp/f1-3781555/mgmt_be_adapter.c:46:
< WARNING: static const char * array should probably be static const char * const
< #61: FILE: /tmp/f1-3781555/mgmt_be_adapter.c:61:
< WARNING: space prohibited between function name and open parenthesis '('
< #134: FILE: /tmp/f1-3781555/mgmt_be_adapter.c:134:
< WARNING: space prohibited between function name and open parenthesis '('
< #990: FILE: /tmp/f1-3781555/mgmt_be_adapter.c:990:
Report for mgmt_be_client.h | 2 issues
===============================================
< ERROR: Macros with multiple statements should be enclosed in a do - while loop
< #43: FILE: /tmp/f1-3781555/mgmt_be_client.h:43:
Report for mgmt_msg_native.h | 15 issues
===============================================
WARNING: Missing a blank line after declarations
#59: FILE: /tmp/f1-3781555/mgmt_msg_native.h:59:
+	int16_t error;
+	alignas(8) char errstr[];

WARNING: Missing a blank line after declarations
#70: FILE: /tmp/f1-3781555/mgmt_msg_native.h:70:
+	uint8_t result_type;
+	alignas(8) char xpath[];

WARNING: Missing a blank line after declarations
#80: FILE: /tmp/f1-3781555/mgmt_msg_native.h:80:
+	uint8_t result_type;
+	alignas(8) uint8_t result[];
Report for yang.c | 6 issues
===============================================
< WARNING: Consider removing the #if 1 and its #endif
< #257: FILE: /tmp/f1-3781555/yang.c:257:
< WARNING: Missing a blank line after declarations
< #714: FILE: /tmp/f1-3781555/yang.c:714:
< WARNING: Missing a blank line after declarations
< #776: FILE: /tmp/f1-3781555/yang.c:776:

@frrbot frrbot bot added the mgmt FRR Management Infra label Sep 28, 2023
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.14383/frr-source'
In file included from lib/mgmt_msg.c:16:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:66:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:77:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
3 errors generated.
gmake[1]: *** [Makefile:10646: lib/mgmt_msg.lo] Error 1
In file included from lib/mgmt_msg_native.c:9:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
Successful on other platforms/tests
  • CentOS 7 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 amd64 build
  • Redhat 9 amd64 build
  • Redhat 8 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 22.04 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Debian 10 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14383/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.14383/frr-source'
In file included from lib/mgmt_msg.c:16:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:66:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
./lib/mgmt_msg_native.h:77:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]
3 errors generated.
gmake[1]: *** [Makefile:10646: lib/mgmt_msg.lo] Error 1
In file included from lib/mgmt_msg_native.c:9:
./lib/mgmt_msg_native.h:57:2: error: anonymous structs are a Microsoft extension [-Werror,-Wmicrosoft-anon-tag]

Report for mgmt_be_adapter.c | 8 issues
===============================================
< WARNING: static const char * array should probably be static const char * const
< #46: FILE: /tmp/f1-686335/mgmt_be_adapter.c:46:
< WARNING: static const char * array should probably be static const char * const
< #61: FILE: /tmp/f1-686335/mgmt_be_adapter.c:61:
< WARNING: space prohibited between function name and open parenthesis '('
< #134: FILE: /tmp/f1-686335/mgmt_be_adapter.c:134:
< WARNING: space prohibited between function name and open parenthesis '('
< #990: FILE: /tmp/f1-686335/mgmt_be_adapter.c:990:
Report for mgmt_be_client.h | 2 issues
===============================================
< ERROR: Macros with multiple statements should be enclosed in a do - while loop
< #43: FILE: /tmp/f1-686335/mgmt_be_client.h:43:
Report for mgmt_msg_native.h | 15 issues
===============================================
WARNING: Missing a blank line after declarations
#59: FILE: /tmp/f1-686335/mgmt_msg_native.h:59:
+	int16_t error;
+	alignas(8) char errstr[];

WARNING: Missing a blank line after declarations
#70: FILE: /tmp/f1-686335/mgmt_msg_native.h:70:
+	uint8_t result_type;
+	alignas(8) char xpath[];

WARNING: Missing a blank line after declarations
#80: FILE: /tmp/f1-686335/mgmt_msg_native.h:80:
+	uint8_t result_type;
+	alignas(8) uint8_t result[];
Report for yang.c | 6 issues
===============================================
< WARNING: Consider removing the #if 1 and its #endif
< #257: FILE: /tmp/f1-686335/yang.c:257:
< WARNING: Missing a blank line after declarations
< #714: FILE: /tmp/f1-686335/yang.c:714:
< WARNING: Missing a blank line after declarations
< #776: FILE: /tmp/f1-686335/yang.c:776:

@frrbot frrbot bot added the bugfix label Oct 3, 2023
@choppsv1 choppsv1 force-pushed the oper-state branch 3 times, most recently from fe37fc8 to 77cadfb Compare October 6, 2023 09:03
@frrbot frrbot bot added the zebra label Oct 6, 2023
@choppsv1 choppsv1 force-pushed the oper-state branch 9 times, most recently from a251d8e to 38d2567 Compare October 13, 2023 10:46
@choppsv1
lib: step 1: mgmtd: add FE get-tree functionality
772f6c0 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: step 2: mgmtd: BE client code for get-tree functionality
4fee273 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
mgmtd: step 3: BE adapter native message handling
33b9c2e 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
mgmtd: step 4: FE adapter get-tree functionality
be2424a 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
mgmtd: step 5: add get-tree txn functionality
8df542b 
Adds the guts of the get-tree functionality that is called by or calls
the FE and BE code for get-tree processing.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
mgmtd: step 6: remove old unfinished get-data code
9cd8693 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1 choppsv1 force-pushed the oper-state branch 2 times, most recently from f99e6af to 91cdc8d Compare December 28, 2023 12:09
@choppsv1
tests: add debugs and count in static_simple test
1bb6f21 
Also add option to use unified config.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: darr: add new access and str functions
f3d6edc 
- darr_last(), and darr_strdup_cap().
- strcat, strdup, strlen, strnul equivs.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: yang: add new functions
db0211d 
- yang_get_key_preds
- yang_lyd_new_list

A function like new_list was added recently to libyang,
this is a compat version.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: northbound: improve xpath functionality
d58653a 
Allow user to leave keys off of a list entry node at the end of the xpath. This
will return all list entries. Previously there was no way to just get the list
entries. One had to leave off the last list entry node which would then return
all list nodes as well as all the siblings at the same level.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: create and use libyang tree during oper-state walk
408ee24 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
tools: add more libyang iter macros to .clang-format
60a8cf7 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: yang: add yang_get_node_keys() function
356c01b 
- comment out unused mem-leaking function.
- improve yang_dnode_get_path return type

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: darr: add ability to set MTYPE for dynamic arrays
b7db6b2 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: northbound: add yielding and batching to oper-state queries
ad1ccb6 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: add dedicated API functions for native msgs
4e0147a 
- reorg native message header

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
zebra: add zebra to mgmtd oper-state
ef91d34 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
zebra: support yielding between oper state routes query
d266b1c 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
zebra: fix oper-state walk bug
c521d45 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
zebra: fix cleanup of mgmt backend state
d0f71a9 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
lib: fixes required after rebasing
b8b5290 
lib: fix checkpatch warnings
lib: darr: disable check
mgmtd: fix initialization

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
tests: client testing
2bb115f 
Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1
tests: add mgmt_oper topotest
f725838 
Signed-off-by: Christian Hopps <chopps@labn.net>
@idryzhov idryzhov merged commit 353ee7b into FRRouting:master Dec 29, 2023
9 checks passed
@choppsv1 choppsv1 deleted the oper-state branch December 31, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryzhov idryzhov idryzhov approved these changes

Assignees
No one assigned
Labels
bugfix documentation libfrr master mgmt FRR Management Infra ospf size/XXL tests Topotests, make check, etc tools yang zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@choppsv1 @NetDEF-CI @idryzhov