nhrp: add cisco-authentication password support
#14788
Draft
+242
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
requested changes
Nov 14, 2023
|
general remark: apply 'git clang-format HEAD^' and squash the proposed changes. |
|
@louberger can you take a look at this? |
volodymyrhuti
force-pushed
the
NHRP_CISCO_AUTH
branch
from
eebc70a
to
aaf720c
Compare
volodymyrhuti
force-pushed
the
NHRP_CISCO_AUTH
branch
2 times, most recently
from
eeae138
to
282a6e5
Compare
|
The latest update:
The internal testing by my team has shown issues when connecting with Cisco Spoke; keep PR as a draft until addressed |
Implemented: - handling 8 char long password, aka Cisco style. - minimal error inidication routine - test case, password change affects conection Signed-off-by: Volodymyr Huti <v.huti@vyos.io>
volodymyrhuti
force-pushed
the
NHRP_CISCO_AUTH
branch
from
282a6e5
to
41b4a29
Compare
|
@ton31337 @pguibert6WIND is anything else needed to tmerge this PR ? |
|
It won't be reviewed until it's marked as a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented:
Implemented in the context - https://vyos.dev/T2326