ospfd: can not delete "segment-routing node-msd" when SR if off #15333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the initial implementation of commit 7743f2f ("OSPFd: Update Segment Routing PR following review") where it wsa not possible to remove the "segment-routing node-msd" CLI nodes via vtysh once segment-routing got disabled. Closes FRRouting#14910 Signed-off-by: Christian Breunig <christian@breunig.cc>
|
LGTM. |
11 tasks
|
@Mergifyio backport stable/9.1 stable/9.0 |
✅ Backports have been created
|
This was referenced Feb 9, 2024
donaldsharp
added a commit
that referenced
this pull request
Feb 9, 2024
ospfd: can not delete "segment-routing node-msd" when SR if off (backport #15333)
donaldsharp
added a commit
that referenced
this pull request
Feb 9, 2024
ospfd: can not delete "segment-routing node-msd" when SR if off (backport #15333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the initial implementation of commit 7743f2f ("OSPFd: Update Segment Routing PR following review") where it wsa not possible to remove the "segment-routing node-msd" CLI nodes via vtysh once segment-routing got disabled.
Closes #14910
Should be backported to
stable/9.0andstable/9.1