lib: add debugs for interface lib module events #15522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add debugs to the interface library, and to a couple of zebra interface- and vrf-message apis. Signed-off-by: Mark Stapp <mjs@cisco.com>
idryzhov
requested changes
Mar 11, 2024
Add cli, handlers, and yang model for 'debug interface'. This was a little awkward; had to put the actual cli in one lib module and offer some support apis from the interface module. Signed-off-by: Mark Stapp <mjs@cisco.com>
|
quite right - updated with a yang model change.
|
|
I wanted to provide some example of how I think debug should be implemented in NB/mgmtd, but unfortunately it's not possible to implement it before #15594 is merged (RPCs are necessary for temporary debug settings from the "enable" node). For now I opened a PR #15646 that simplifies the debug module in frrlib and makes it easier to use. As NB can't be implemented properly right now, I'm fine with this PR without NB if it starts using the libfrr debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some debugs for interface lib events, similar to what is present with "debug vrf".