added managed redistribution in ISIS #15617
Conversation
Sashhkaa
force-pushed
the
multiarea
branch
5 times, most recently
from
e669fe5
to
aebd626
Compare
isisd/isis_cli.c
Outdated
| @@ -85,13 +85,13 @@ void cli_show_router_isis(struct vty *vty, const struct lyd_node *dnode, | |||
| { | |||
| const char *vrf = NULL; | |||
|
|
|||
| vrf = yang_dnode_get_string(dnode, "vrf"); | |||
| vrf = yang_dnode_get_string(dnode, "./vrf"); | |||
There was a problem hiding this comment.
Please, remove all these unrelated changes.
isisd/isis_cli.c
Outdated
| /* | ||
| * XPath: /frr-isisd:isis/instance/route_leanking | ||
| */ | ||
| DEFPY_YANG(isis_leanking, isis_leanking_cmd, |
There was a problem hiding this comment.
First, this should be leaking, not leaNking. This needs to be fixed everywhere in the code.
Second, I think it should be a part of the regular redistribute command. For example, that's how you configure this on Cisco:
redistribute isis ip level-2 into level-1 route-map r1
IMO we should just use the same command, there's no need to introduce new commands and new terminology.
isisd/isis_redist.c
Outdated
| @@ -585,6 +690,85 @@ void isis_redist_area_finish(struct isis_area *area) | |||
| } | |||
|
|
|||
| #ifdef FABRICD | |||
| DEFUN(isis_leanking, isis_leanking_cmd, | |||
There was a problem hiding this comment.
Same comments about the command here.
| @@ -104,6 +104,16 @@ module frr-isisd { | |||
| description | |||
| "This enum indicates capability for both levels."; | |||
| } | |||
| enum "level2_to_level1" { | |||
There was a problem hiding this comment.
There are no such levels in IS-IS, it shouldn't be modeled like this. More comments below.
yang/frr-isisd.yang
Outdated
| @@ -2078,6 +2109,45 @@ module frr-isisd { | |||
| } | |||
| } | |||
|
|
|||
| container route_leanking { | |||
There was a problem hiding this comment.
We don't need this new container to model IS-IS to IS-IS redistribution. It is enough to modify the existing redistribute container:
- remove
must ". != \"isis\"";fromleaf protocolto allow redistribution from IS-IS - add a new
from-levelleaf to configure from which level to redistribute:leaf from-level { type level; when "../protocol = \"isis\""; mandatory true; must "(. != \"level-1-2\") and ((../../../is-type = \"level-1-2\") and (. != ../level))"; description "IS-IS level from which the routes should be redistributed."; }
These two changes would be enough to model what you need without introducing a lot of new NB callbacks.
squirrelking57
force-pushed
the
multiarea
branch
from
bb9750a
to
8cfa3b5
Compare
Sashhkaa
force-pushed
the
multiarea
branch
2 times, most recently
from
9aabe4a
to
4b6cff3
Compare
Sashhkaa
force-pushed
the
multiarea
branch
3 times, most recently
from
5050c31
to
78a577c
Compare
1) added command "redistribute ipv4/ipv6 isis level-m into level-n route-map name" in cli according to RFC5302 2) added adding prefixes with the best metric from the level-1 db to the level-2 db on l1_l2 end system Signed-off-by: squirrelking57 <1248756005hfh@gmail.com>
|
There is no need for a review at the moment, it needs improvement |
|
created a new beautiful and good pull request #15863 |
added command "route_leaking ipv4/ipv6 level's route-map name" in cli according to RFC5302