bgpd: Fix error handling when receiving BGP Prefix SID attribute #15628
+25
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
force-pushed
the
fix/bgp_prefix_sid_crash
branch
2 times, most recently
from
b1c1046
to
b33004e
Compare
|
CI:rerun libyang version may have changed during execution which caused the failure |
Without this patch, we always set the BGP Prefix SID attribute flag without checking if it's malformed or not. RFC8669 says that this attribute MUST be discarded. Also, this fixes the bgpd crash when a malformed Prefix SID attribute is received, with malformed transitive flags and/or TLVs. Reported-by: Iggy Frankovic <iggyfran@amazon.com> Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ton31337
force-pushed
the
fix/bgp_prefix_sid_crash
branch
from
b33004e
to
b33d0b9
Compare
|
@Mergifyio backport dev/10.0 stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
If we receive an attribute that is handled by bgp_attr_malformed(), use treat-as-withdraw behavior for unknown (or missing to add - if new) attributes. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ton31337
force-pushed
the
fix/bgp_prefix_sid_crash
branch
from
b33d0b9
to
babb23b
Compare
This was referenced Apr 2, 2024
ton31337
added a commit
that referenced
this pull request
Apr 2, 2024
bgpd: Fix error handling when receiving BGP Prefix SID attribute (backport #15628)
ton31337
added a commit
that referenced
this pull request
Apr 3, 2024
bgpd: Fix error handling when receiving BGP Prefix SID attribute (backport #15628)
ton31337
added a commit
that referenced
this pull request
Apr 3, 2024
bgpd: Fix error handling when receiving BGP Prefix SID attribute (backport #15628)
ton31337
added a commit
that referenced
this pull request
Apr 5, 2024
bgpd: Fix error handling when receiving BGP Prefix SID attribute (backport #15628)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.