Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify debug library #15646

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

simplify debug library #15646

wants to merge 4 commits into from

Commits on Apr 1, 2024

  1. pathd: rework debugs 

    Pathd uses a single debug struct with additional option flags to
configure different types of debug messages. This is not how debug
library is supposed to be used. The idea of option flags is to allow
more granular control of a single type, not to represent multiple types.

This commit adds a separate debug struct for each type which greatly
simplifies the code.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
    @idryzhov
    idryzhov committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    fe39a60 View commit details
    Browse the repository at this point in the history

  2. lib: rework debug init 

    The debug library allows to register a `debug_set_all` callback which
should enable all debugs in a daemon. This callback is implemented
exactly the same in each daemon. Instead of duplicating the code, rework
the lib to allow registration of each debug type, and implement the
common code only once in the lib.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
    @idryzhov
    idryzhov committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b0e6f69 View commit details
    Browse the repository at this point in the history

  3. lib: common debug config output 

    Implement common code for debug config output and remove daemon-specific
code that is duplicated everywhere.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
    @idryzhov
    idryzhov committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e2e597f View commit details
    Browse the repository at this point in the history

  4. lib: common debug status output 

    Implement common code for debug status output and remove daemon-specific
code that is duplicated everywhere.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
    @idryzhov
    idryzhov committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e0ce651 View commit details
    Browse the repository at this point in the history